Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: chrome/browser/extensions/crx_installer.cc

Issue 8198003: Convert app_launch_index and page_index from int to StringOrdinal. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/crx_installer.h" 5 #include "chrome/browser/extensions/crx_installer.h"
6 6
7 #include <map> 7 #include <map>
8 #include <set> 8 #include <set>
9 9
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 } 114 }
115 115
116 CrxInstaller::CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak, 116 CrxInstaller::CrxInstaller(base::WeakPtr<ExtensionService> frontend_weak,
117 ExtensionInstallUI* client) 117 ExtensionInstallUI* client)
118 : install_directory_(frontend_weak->install_directory()), 118 : install_directory_(frontend_weak->install_directory()),
119 install_source_(Extension::INTERNAL), 119 install_source_(Extension::INTERNAL),
120 extensions_enabled_(frontend_weak->extensions_enabled()), 120 extensions_enabled_(frontend_weak->extensions_enabled()),
121 delete_source_(false), 121 delete_source_(false),
122 is_gallery_install_(false), 122 is_gallery_install_(false),
123 create_app_shortcut_(false), 123 create_app_shortcut_(false),
124 page_index_(-1), 124 page_index_(extension_misc::kUnsetIndex),
125 frontend_weak_(frontend_weak), 125 frontend_weak_(frontend_weak),
126 client_(client), 126 client_(client),
127 apps_require_extension_mime_type_(false), 127 apps_require_extension_mime_type_(false),
128 allow_silent_install_(false), 128 allow_silent_install_(false),
129 install_cause_(extension_misc::INSTALL_CAUSE_UNSET) { 129 install_cause_(extension_misc::INSTALL_CAUSE_UNSET) {
130 } 130 }
131 131
132 CrxInstaller::~CrxInstaller() { 132 CrxInstaller::~CrxInstaller() {
133 // Delete the temp directory and crx file as necessary. Note that the 133 // Delete the temp directory and crx file as necessary. Note that the
134 // destructor might be called on any thread, so we post a task to the file 134 // destructor might be called on any thread, so we post a task to the file
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
586 // Some users (such as the download shelf) need to know when a 586 // Some users (such as the download shelf) need to know when a
587 // CRXInstaller is done. Listening for the EXTENSION_* events 587 // CRXInstaller is done. Listening for the EXTENSION_* events
588 // is problematic because they don't know anything about the 588 // is problematic because they don't know anything about the
589 // extension before it is unpacked, so they can not filter based 589 // extension before it is unpacked, so they can not filter based
590 // on the extension. 590 // on the extension.
591 NotificationService::current()->Notify( 591 NotificationService::current()->Notify(
592 chrome::NOTIFICATION_CRX_INSTALLER_DONE, 592 chrome::NOTIFICATION_CRX_INSTALLER_DONE,
593 Source<CrxInstaller>(this), 593 Source<CrxInstaller>(this),
594 NotificationService::NoDetails()); 594 NotificationService::NoDetails());
595 } 595 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698