Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 8197002: Fix some array functions to behave as specified. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger
Modified:
9 years, 2 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix some array functions to behave as specified. This fixes the handling of primitives and the order of how side effects are visible in some array functions as specified by the ES5. R=rossberg@chromium.org TEST=test262 Committed: http://code.google.com/p/v8/source/detail?r=9549

Patch Set 1 #

Patch Set 2 : Fix order of side effects in some array functions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -192 lines) Patch
M src/array.js View 1 9 chunks +66 lines, -45 lines 0 comments Download
M test/test262/test262.status View 1 6 chunks +0 lines, -147 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
PTAL.
9 years, 2 months ago (2011-10-07 09:26:44 UTC) #1
rossberg
9 years, 2 months ago (2011-10-07 13:59:45 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698