Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 8195003: Initialize glib for all linux variants (Closed)

Created:
9 years, 2 months ago by oshima
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam
Visibility:
Public.

Description

Initialize glib for all linux because all linux variants uses glib. aura chrome fails on ubuntu 11.04 without this remove base::MessagePumpX::DisableGtkMessagePump() from aura as we nolonger has gtk on aura. BUG=97131 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104508

Patch Set 1 #

Patch Set 2 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/browser/browser_main.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
9 years, 2 months ago (2011-10-07 08:02:24 UTC) #1
Emmanuel Saint-loubert-Bié
LGTM. jam@?
9 years, 2 months ago (2011-10-07 14:25:00 UTC) #2
jam
lgtm
9 years, 2 months ago (2011-10-07 16:05:19 UTC) #3
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8195003/2001
9 years, 2 months ago (2011-10-07 16:14:54 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 17:34:23 UTC) #5
Change committed as 104508

Powered by Google App Engine
This is Rietveld 408576698