Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 8194012: Merge revision 9585 and revision 9580 to trunk. (Closed)

Created:
9 years, 2 months ago by Rico
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge revision 9585 and revision 9580 to trunk. Revision 9585: Fix free list node ending up on evacuation candidate. This is a temporary fix which avoids compaction when incremental marking is restarted during an old-space-step. That could turn the page that holds the chosen free list node into an evacuation candidate. It could also cause several other inconsistencies if it happens during scavenge. Revision 9580: Adjust assertions in the incremental marking. Now we are completely transfering marks when shifting arrays in-place. This might lead to white free space objects in the marking deque. Committed: http://code.google.com/p/v8/source/detail?r=9586

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M src/incremental-marking.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/incremental-marking.cc View 1 7 chunks +16 lines, -8 lines 0 comments Download
M src/spaces.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Rico
9 years, 2 months ago (2011-10-11 17:22:48 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 2 months ago (2011-10-11 17:32:17 UTC) #2
lgtm if compiles

Powered by Google App Engine
This is Rietveld 408576698