Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 8190008: ntp4: hack around skia gradient brokenness. (Closed)

Created:
9 years, 2 months ago by Evan Stade
Modified:
9 years, 2 months ago
CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

ntp4: hack around skia gradient brokenness. (you'll notice in the bug report the window in the screenshot is really wide --- this only affects wider browser windows). BUG=99373 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104564

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/resources/ntp4/tile_page.js View 1 chunk +8 lines, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
Evan Stade
Dan: can you confirm the test case I posted to the bug shows the problem ...
9 years, 2 months ago (2011-10-07 02:16:47 UTC) #1
Dan Beam
On 2011/10/07 02:16:47, Evan Stade wrote: > Dan: can you confirm the test case I ...
9 years, 2 months ago (2011-10-07 18:34:27 UTC) #2
csilv
LGTM On Mac, the bug is not reproducible before and after the patch. I can ...
9 years, 2 months ago (2011-10-07 19:45:25 UTC) #3
Evan Stade
great thanks.
9 years, 2 months ago (2011-10-07 19:54:47 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8190008/1
9 years, 2 months ago (2011-10-07 19:54:58 UTC) #5
Dan Beam
http://codereview.chromium.org/8190008/diff/1/chrome/browser/resources/ntp4/tile_page.js File chrome/browser/resources/ntp4/tile_page.js (right): http://codereview.chromium.org/8190008/diff/1/chrome/browser/resources/ntp4/tile_page.js#newcode732 chrome/browser/resources/ntp4/tile_page.js:732: if (!cr.isMac) I still think you should mention in ...
9 years, 2 months ago (2011-10-07 20:05:42 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 21:21:53 UTC) #7
Change committed as 104564

Powered by Google App Engine
This is Rietveld 408576698