Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5551)

Unified Diff: chrome/browser/sync/protocol/client_debug_info.proto

Issue 8189003: Send important client side event information to the server. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For review. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/protocol/client_debug_info.proto
diff --git a/chrome/browser/sync/protocol/client_debug_info.proto b/chrome/browser/sync/protocol/client_debug_info.proto
new file mode 100644
index 0000000000000000000000000000000000000000..e8c758c68e498339a1ad81230c212cacea3f293d
--- /dev/null
+++ b/chrome/browser/sync/protocol/client_debug_info.proto
@@ -0,0 +1,45 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Common sync protocol for encrypted data.
+
+// Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
+// any fields in this file.
+
+syntax = "proto2";
+
+option optimize_for = LITE_RUNTIME;
+option retain_unknown_fields = true;
+
+package sync_pb;
+
+message SyncCycleCompletedEventInfo {
+ optional bool syncer_stuck = 1;
tim (not reviewing) 2011/10/14 01:23:21 perhaps add a comment at the message level here sa
lipalani1 2011/10/14 18:31:10 Done.
+ optional int32 num_blocking_conflicts = 2;
+ optional int32 num_non_blocking_conflicts = 3;
+}
+
+message DebugEventInfo {
+ // These events dont have any extra info associated with them.
tim (not reviewing) 2011/10/14 01:23:21 What's extra info? Might be more helpful to write
lipalani1 2011/10/14 18:31:10 Done.
+ enum EventType {
+ AUTH_ERROR = 1; // Auth error
tim (not reviewing) 2011/10/14 01:23:21 add period. this comment isn't that useful either
lipalani1 2011/10/14 18:31:10 Done.
+ UPDATED_TOKEN = 2; // Client received an updated token.
+ PASSPHRASE_REQUIRED = 3; // Cryptographer needs passphrase.
+ PASSPHRASE_ACCEPTED = 4; // Passphrase was accepted by cryptographer.
+ INITIALIZATION_COMPLETE = 5; // Sync Initialization is complete.
+ // This event should never be seen by the server in the absence of bugs.
tim (not reviewing) 2011/10/14 01:23:21 Which event does this pertain to?
lipalani1 2011/10/14 18:31:10 Done.
+ STOP_SYNCING_PERMANENTLY = 6; // Server sent stop syncing permanently.
+ ENCRYPTION_COMPLETE = 7; // Client has finished encrypting all data.
+ ACTIONABLE_ERROR = 8; // Client received an actionable error.
+ }
+ optional EventType type = 1;
+ optional SyncCycleCompletedEventInfo sync_cycle_completed_event_info = 2;
+}
+
+message DebugInfo {
+ repeated DebugEventInfo events = 1;
+ optional bool cryptographer_ready = 2;
+ optional bool cryptographer_has_pending_keys = 3;
tim (not reviewing) 2011/10/14 01:23:21 comments on these
lipalani1 2011/10/14 18:31:10 Done.
+ optional bool events_dropped = 4;
+}

Powered by Google App Engine
This is Rietveld 408576698