Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/sync/abstract_profile_sync_service_test.cc

Issue 8184001: The AutofillProfileSyncableService's lifetime should be managed by the WebDataService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ensure that destruction occurs on the DB thread Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/abstract_profile_sync_service_test.cc
diff --git a/chrome/browser/sync/abstract_profile_sync_service_test.cc b/chrome/browser/sync/abstract_profile_sync_service_test.cc
index 19cb8fa74aa3b0f3ec2103e8481a02bf706d8f28..02da55cb1ea792b4fd3dcc09dcb1e88cf9ad4f4c 100644
--- a/chrome/browser/sync/abstract_profile_sync_service_test.cc
+++ b/chrome/browser/sync/abstract_profile_sync_service_test.cc
@@ -39,9 +39,9 @@ const std::string ProfileSyncServiceTestHelper::GetTagForType(
}
/* static */
-bool ProfileSyncServiceTestHelper::CreateRoot(
- ModelType model_type, UserShare* user_share,
- TestIdFactory* ids) {
+bool ProfileSyncServiceTestHelper::CreateRoot(ModelType model_type,
akalin 2011/10/10 21:58:57 revert these diffs please (as far as I can tell, t
Ilya Sherman 2011/10/10 22:33:13 Done.
+ UserShare* user_share,
+ TestIdFactory* ids) {
DirectoryManager* dir_manager = user_share->dir_manager.get();
ScopedDirLookup dir(dir_manager, user_share->name);
@@ -119,12 +119,16 @@ bool AbstractProfileSyncServiceTest::CreateRoot(ModelType model_type) {
service_->id_factory());
}
-CreateRootTask::CreateRootTask(
- AbstractProfileSyncServiceTest* test, ModelType model_type)
- : test_(test), model_type_(model_type), success_(false) {
+CreateRootTask::CreateRootTask(AbstractProfileSyncServiceTest* test,
+ ModelType model_type)
+ : test_(test),
+ model_type_(model_type),
+ success_(false) {
+}
+
+CreateRootTask::~CreateRootTask() {
}
-CreateRootTask::~CreateRootTask() {}
void CreateRootTask::Run() {
success_ = test_->CreateRoot(model_type_);
}

Powered by Google App Engine
This is Rietveld 408576698