chrome/browser/sync/profile_sync_factory_impl.cc - Issue 8184001: The AutofillProfileSyncableService's lifetime should be managed by the WebDataService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_factory_impl.cc

Issue 8184001: The AutofillProfileSyncableService's lifetime should be managed by the WebDataService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile after http://crrev.com/104990 Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/profile_sync_factory_impl.cc

diff --git a/chrome/browser/sync/profile_sync_factory_impl.cc b/chrome/browser/sync/profile_sync_factory_impl.cc

index 5f093e3810f03e83b86e558008482afa11f262e8..f38c9ba9b26d08a23250e614bbd1d88232c273cb 100644

--- a/chrome/browser/sync/profile_sync_factory_impl.cc

+++ b/chrome/browser/sync/profile_sync_factory_impl.cc

@@ -51,7 +51,6 @@ using browser_sync::AutofillChangeProcessor;

using browser_sync::AutofillDataTypeController;

using browser_sync::AutofillProfileDataTypeController;

using browser_sync::AutofillModelAssociator;

-using browser_sync::AutofillProfileSyncableService;

using browser_sync::BookmarkChangeProcessor;

using browser_sync::BookmarkDataTypeController;

using browser_sync::BookmarkModelAssociator;

@@ -223,7 +222,7 @@ ProfileSyncFactoryImpl::CreateAutofillProfileSyncComponents(

WebDataService* web_data_service,

browser_sync::UnrecoverableErrorHandler* error_handler) {

AutofillProfileSyncableService* sync_service =

- new AutofillProfileSyncableService(web_data_service);

+ web_data_service->GetAutofillProfileSyncableService();

sync_api::UserShare* user_share = profile_sync_service->GetUserShare();

GenericChangeProcessor* change_processor =

new GenericChangeProcessor(sync_service, error_handler, user_share);

« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service_autofill_unittest.cc » ('j') | no next file with comments »