Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/sync/profile_sync_factory_impl.cc

Issue 8184001: The AutofillProfileSyncableService's lifetime should be managed by the WebDataService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ensure that destruction occurs on the DB thread Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "chrome/browser/extensions/extension_service.h" 6 #include "chrome/browser/extensions/extension_service.h"
7 #include "chrome/browser/extensions/extension_settings_backend.h" 7 #include "chrome/browser/extensions/extension_settings_backend.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/search_engines/template_url_service.h" 9 #include "chrome/browser/search_engines/template_url_service.h"
10 #include "chrome/browser/search_engines/template_url_service_factory.h" 10 #include "chrome/browser/search_engines/template_url_service_factory.h"
(...skipping 23 matching lines...) Expand all
34 #include "chrome/browser/sync/glue/theme_change_processor.h" 34 #include "chrome/browser/sync/glue/theme_change_processor.h"
35 #include "chrome/browser/sync/glue/theme_data_type_controller.h" 35 #include "chrome/browser/sync/glue/theme_data_type_controller.h"
36 #include "chrome/browser/sync/glue/theme_model_associator.h" 36 #include "chrome/browser/sync/glue/theme_model_associator.h"
37 #include "chrome/browser/sync/glue/typed_url_change_processor.h" 37 #include "chrome/browser/sync/glue/typed_url_change_processor.h"
38 #include "chrome/browser/sync/glue/typed_url_data_type_controller.h" 38 #include "chrome/browser/sync/glue/typed_url_data_type_controller.h"
39 #include "chrome/browser/sync/glue/typed_url_model_associator.h" 39 #include "chrome/browser/sync/glue/typed_url_model_associator.h"
40 #include "chrome/browser/sync/profile_sync_service.h" 40 #include "chrome/browser/sync/profile_sync_service.h"
41 #include "chrome/browser/sync/profile_sync_factory_impl.h" 41 #include "chrome/browser/sync/profile_sync_factory_impl.h"
42 #include "chrome/browser/sync/signin_manager.h" 42 #include "chrome/browser/sync/signin_manager.h"
43 #include "chrome/browser/webdata/autofill_profile_syncable_service.h" 43 #include "chrome/browser/webdata/autofill_profile_syncable_service.h"
44 #include "chrome/browser/webdata/autofill_table.h"
45 #include "chrome/browser/webdata/web_database.h"
44 #include "chrome/browser/webdata/web_data_service.h" 46 #include "chrome/browser/webdata/web_data_service.h"
45 #include "chrome/common/chrome_switches.h" 47 #include "chrome/common/chrome_switches.h"
46 #include "chrome/common/pref_names.h" 48 #include "chrome/common/pref_names.h"
47 #include "content/browser/browser_thread.h" 49 #include "content/browser/browser_thread.h"
48 50
49 using browser_sync::AppDataTypeController; 51 using browser_sync::AppDataTypeController;
50 using browser_sync::AutofillChangeProcessor; 52 using browser_sync::AutofillChangeProcessor;
51 using browser_sync::AutofillDataTypeController; 53 using browser_sync::AutofillDataTypeController;
52 using browser_sync::AutofillProfileDataTypeController; 54 using browser_sync::AutofillProfileDataTypeController;
53 using browser_sync::AutofillModelAssociator; 55 using browser_sync::AutofillModelAssociator;
54 using browser_sync::AutofillProfileSyncableService;
55 using browser_sync::BookmarkChangeProcessor; 56 using browser_sync::BookmarkChangeProcessor;
56 using browser_sync::BookmarkDataTypeController; 57 using browser_sync::BookmarkDataTypeController;
57 using browser_sync::BookmarkModelAssociator; 58 using browser_sync::BookmarkModelAssociator;
58 using browser_sync::DataTypeController; 59 using browser_sync::DataTypeController;
59 using browser_sync::DataTypeManager; 60 using browser_sync::DataTypeManager;
60 using browser_sync::DataTypeManagerImpl; 61 using browser_sync::DataTypeManagerImpl;
61 using browser_sync::ExtensionDataTypeController; 62 using browser_sync::ExtensionDataTypeController;
62 using browser_sync::ExtensionSettingDataTypeController; 63 using browser_sync::ExtensionSettingDataTypeController;
63 using browser_sync::GenericChangeProcessor; 64 using browser_sync::GenericChangeProcessor;
64 using browser_sync::PasswordChangeProcessor; 65 using browser_sync::PasswordChangeProcessor;
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 error_handler); 217 error_handler);
217 return SyncComponents(model_associator, change_processor); 218 return SyncComponents(model_associator, change_processor);
218 } 219 }
219 220
220 ProfileSyncFactory::SyncComponents 221 ProfileSyncFactory::SyncComponents
221 ProfileSyncFactoryImpl::CreateAutofillProfileSyncComponents( 222 ProfileSyncFactoryImpl::CreateAutofillProfileSyncComponents(
222 ProfileSyncService* profile_sync_service, 223 ProfileSyncService* profile_sync_service,
223 WebDatabase* web_database, 224 WebDatabase* web_database,
224 browser_sync::UnrecoverableErrorHandler* error_handler) { 225 browser_sync::UnrecoverableErrorHandler* error_handler) {
225 AutofillProfileSyncableService* sync_service = 226 AutofillProfileSyncableService* sync_service =
226 new AutofillProfileSyncableService(web_database, 227 web_database->GetAutofillTable()->GetSyncableService(
227 profile_sync_service->profile()); 228 web_database, profile_sync_service->profile());
228 sync_api::UserShare* user_share = profile_sync_service->GetUserShare(); 229 sync_api::UserShare* user_share = profile_sync_service->GetUserShare();
229 GenericChangeProcessor* change_processor = 230 GenericChangeProcessor* change_processor =
230 new GenericChangeProcessor(sync_service, error_handler, user_share); 231 new GenericChangeProcessor(sync_service, error_handler, user_share);
231 browser_sync::SyncableServiceAdapter* sync_service_adapter = 232 browser_sync::SyncableServiceAdapter* sync_service_adapter =
232 new browser_sync::SyncableServiceAdapter(syncable::AUTOFILL_PROFILE, 233 new browser_sync::SyncableServiceAdapter(syncable::AUTOFILL_PROFILE,
233 sync_service, 234 sync_service,
234 change_processor); 235 change_processor);
235 return SyncComponents(sync_service_adapter, change_processor); 236 return SyncComponents(sync_service_adapter, change_processor);
236 } 237 }
237 238
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 DCHECK(se_sync_service); 367 DCHECK(se_sync_service);
367 sync_api::UserShare* user_share = profile_sync_service->GetUserShare(); 368 sync_api::UserShare* user_share = profile_sync_service->GetUserShare();
368 GenericChangeProcessor* change_processor = 369 GenericChangeProcessor* change_processor =
369 new GenericChangeProcessor(se_sync_service, error_handler, user_share); 370 new GenericChangeProcessor(se_sync_service, error_handler, user_share);
370 SyncableServiceAdapter* sync_service_adapter = 371 SyncableServiceAdapter* sync_service_adapter =
371 new SyncableServiceAdapter(syncable::SEARCH_ENGINES, 372 new SyncableServiceAdapter(syncable::SEARCH_ENGINES,
372 se_sync_service, 373 se_sync_service,
373 change_processor); 374 change_processor);
374 return SyncComponents(sync_service_adapter, change_processor); 375 return SyncComponents(sync_service_adapter, change_processor);
375 } 376 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698