Choose the right window to switch to when a panel is deactivated on Windows.

chrome/browser/ui/panels/panel_browser_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_view.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
@@ skipping 57 matching lines @@
   GetWidget()->RemoveObserver(this);
   closed_ = true;
 
   // Cancel any currently running animation since we're closing down.
   if (bounds_animator_.get())
     bounds_animator_.reset();
 
   ::BrowserView::Close();
 }
 
+void PanelBrowserView::Deactivate() {
+  if (!IsActive())
+    return;
+
+#if defined(OS_WIN)
+  gfx::NativeWindow native_window = NULL;
+  BrowserWindow* browser_window =
+      panel_->manager()->GetNextPanelToActivate(panel_.get());

[Dmitry Titov, 2011/10/07 20:29:15]

This can be split in 2 methods - platform-independent part that activates next
window, perhaps implemented in Panel::Deactivate() itself, and
platform-dependent "deactivate app" which probably should be in win_util
somewhere... and called form Panel::Deactivate().

[jianli, 2011/10/07 22:01:54]

As discussed, we keep as it is since the only thing we can move to Panel is the
call to PanelManager::GetNextBrowserWindowToActivate. Since it is simply one
line of code, we rather keep it here for simplicity.

+  if (browser_window)
+    native_window = browser_window->GetNativeHandle();
+  else
+    native_window = ::GetDesktopWindow();
+  if (native_window)
+    ::SetForegroundWindow(native_window);
+  else
+    ::SetFocus(NULL);
+#else
+  // TODO(jianli): to be implemented for other platform.
+  BrowserView::Deactivate();
+#endif
+}
+
 bool PanelBrowserView::CanResize() const {
   return false;
 }
 
 bool PanelBrowserView::CanMaximize() const {
   return false;
 }
 
 void PanelBrowserView::SetBounds(const gfx::Rect& bounds) {
   if (bounds_ == bounds)
@@ skipping 354 matching lines @@
   explicit NativePanelTestingWin(PanelBrowserView* panel_browser_view);
 
  private:
   virtual void PressLeftMouseButtonTitlebar(
       const gfx::Point& point) OVERRIDE;
   virtual void ReleaseMouseButtonTitlebar() OVERRIDE;
   virtual void DragTitlebar(int delta_x, int delta_y) OVERRIDE;
   virtual void CancelDragTitlebar() OVERRIDE;
   virtual void FinishDragTitlebar() OVERRIDE;
   virtual bool VerifyDrawingAttention() const OVERRIDE;
-
+  virtual bool VerifyTitlebarPaintedAsActive(bool as_active) OVERRIDE;
 
   PanelBrowserView* panel_browser_view_;
 };
 
 // static
 NativePanelTesting* NativePanelTesting::Create(NativePanel* native_panel) {
   return new NativePanelTestingWin(static_cast<PanelBrowserView*>(
       native_panel));
 }
 
@@ skipping 27 matching lines @@
 void NativePanelTestingWin::FinishDragTitlebar() {
   panel_browser_view_->OnTitlebarMouseReleased();
 }
 
 bool NativePanelTestingWin::VerifyDrawingAttention() const {
   PanelBrowserFrameView* frame_view = panel_browser_view_->GetFrameView();
   SkColor attention_color = frame_view->GetTitleColor(
       PanelBrowserFrameView::PAINT_FOR_ATTENTION);
   return attention_color == frame_view->title_label_->GetColor();
 }
+
+bool NativePanelTestingWin::VerifyTitlebarPaintedAsActive(bool as_active) {
+  PanelBrowserFrameView* frame_view = panel_browser_view_->GetFrameView();
+
+  PanelBrowserFrameView::PaintState expected_paint_state =
+      as_active ? PanelBrowserFrameView::PAINT_AS_ACTIVE
+                : PanelBrowserFrameView::PAINT_AS_INACTIVE;
+  if (frame_view->paint_state_ != expected_paint_state)
+    return false;
+
+  SkColor expected_color = frame_view->GetTitleColor(expected_paint_state);
+  return expected_color == frame_view->title_label_->GetColor();
+}