chrome/browser/ui/panels/native_panel.h - Issue 8183005: Choose the right window to switch to when a panel is deactivated on Windows.

Side by Side Diff: chrome/browser/ui/panels/native_panel.h

Issue 8183005: Choose the right window to switch to when a panel is deactivated on Windows. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/panels/base_panel_browser_test.cc ('k') | chrome/browser/ui/panels/panel_browser_view.h » ('j') | chrome/browser/ui/panels/panel_browser_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_	5 #ifndef CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_

6 #define CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_	6 #define CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_

7 #pragma once	7 #pragma once

8	8

9 #include "chrome/browser/ui/panels/panel.h"	9 #include "chrome/browser/ui/panels/panel.h"

10 #include "ui/gfx/native_widget_types.h"	10 #include "ui/gfx/native_widget_types.h"

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
80 virtual ~NativePanelTesting() {}	80 virtual ~NativePanelTesting() {}

81	81

82 virtual void PressLeftMouseButtonTitlebar(const gfx::Point& point) = 0;	82 virtual void PressLeftMouseButtonTitlebar(const gfx::Point& point) = 0;

83 virtual void ReleaseMouseButtonTitlebar() = 0;	83 virtual void ReleaseMouseButtonTitlebar() = 0;

84 virtual void DragTitlebar(int delta_x, int delta_y) = 0;	84 virtual void DragTitlebar(int delta_x, int delta_y) = 0;

85 virtual void CancelDragTitlebar() = 0;	85 virtual void CancelDragTitlebar() = 0;

86 virtual void FinishDragTitlebar() = 0;	86 virtual void FinishDragTitlebar() = 0;

87 // Verifies, on a deepest possible level, if the Panel is showing the "Draw	87 // Verifies, on a deepest possible level, if the Panel is showing the "Draw

88 // Attention" effects to the user. May include checking colors etc.	88 // Attention" effects to the user. May include checking colors etc.

89 virtual bool VerifyDrawingAttention() const = 0;	89 virtual bool VerifyDrawingAttention() const = 0;

	90 // Verifies, on a deepest possible level, if the titlebar of the Panel is

	91 // being painted correctly per its active state.

	92 virtual bool VerifyTitlebarPaintedAsActive(bool as_active) = 0;
	Dmitry Titov 2011/10/07 20:29:15 Does it verify that the panel is actually active o Does it verify that the panel is actually active or that the color of the titlebar is correct? It's not clear from the description. If it is verifying that the panel is really active, we could name the method VarifyIsActive() and implement it by checking the color of titlebar. It could be a different check on another platform. jianli 2011/10/07 22:01:54 We want to verify that the titlebar is painted cor Show quoted text On 2011/10/07 20:29:15, Dmitry Titov wrote: > Does it verify that the panel is actually active or that the color of the > titlebar is correct? It's not clear from the description. If it is verifying > that the panel is really active, we could name the method VarifyIsActive() and > implement it by checking the color of titlebar. It could be a different check on > another platform. We want to verify that the titlebar is painted correctly per its active state. This is the reason I name it as *PaintedAsActive. Checking whether the panel is active can be done by calling Panel::IsActive. Dmitry Titov 2011/10/07 22:26:41 Same logic here as VerifyDrawingAttention() - the Show quoted text On 2011/10/07 22:01:54, jianli wrote: > On 2011/10/07 20:29:15, Dmitry Titov wrote: > > Does it verify that the panel is actually active or that the color of the > > titlebar is correct? It's not clear from the description. If it is verifying > > that the panel is really active, we could name the method VarifyIsActive() and > > implement it by checking the color of titlebar. It could be a different check > on > > another platform. > > We want to verify that the titlebar is painted correctly per its active state. > This is the reason I name it as *PaintedAsActive. Checking whether the panel > is active can be done by calling Panel::IsActive. Same logic here as VerifyDrawingAttention() - the method is actually implemented differently on various platforms. On Views, it checks for colors, on OSX, it checks for internal flag. It makes sense to name the method by 'what' it does rather then 'how exactly does it do that'. In this particular case, you verify that the native panel actually, really and for sure is drawing 'active' decorations. The 'how' is 'by changing the color of the titlebar'. On OSX, we might again check for internal flag because the colors are not pulled until we actually draw real pixels.
90 };	93 };

91	94

92 #endif // CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_	95 #endif // CHROME_BROWSER_UI_PANELS_NATIVE_PANEL_H_

OLD	NEW