Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: chrome/browser/extensions/extension_settings_frontend_unittest.cc

Issue 8177022: Add onChanged events to the extension settings API, both from sync and between (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: profile fix, comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_settings_frontend_unittest.cc
diff --git a/chrome/browser/extensions/extension_settings_frontend_unittest.cc b/chrome/browser/extensions/extension_settings_frontend_unittest.cc
index 06d774db9b185e45ed9e110075ea41bb3f4ea16d..0d638704df10ac81f646299b1b240ee87773acdb 100644
--- a/chrome/browser/extensions/extension_settings_frontend_unittest.cc
+++ b/chrome/browser/extensions/extension_settings_frontend_unittest.cc
@@ -26,13 +26,13 @@ class ExtensionSettingsFrontendTest : public testing::Test {
virtual void SetUp() OVERRIDE {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
- frontend_.reset(new ExtensionSettingsFrontend(temp_dir_.path()));
profile_.reset(new TestingProfile(temp_dir_.path()));
+ frontend_.reset(new ExtensionSettingsFrontend(profile_.get()));
}
virtual void TearDown() OVERRIDE {
- profile_.reset();
frontend_.reset();
+ profile_.reset();
}
protected:
@@ -48,8 +48,8 @@ class ExtensionSettingsFrontendTest : public testing::Test {
}
ScopedTempDir temp_dir_;
- scoped_ptr<ExtensionSettingsFrontend> frontend_;
scoped_ptr<TestingProfile> profile_;
+ scoped_ptr<ExtensionSettingsFrontend> frontend_;
private:
// Intended as a ExtensionSettingsFrontend::BackendCallback from GetBackend.
@@ -80,7 +80,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsPreservedAcrossReconstruction) {
ASSERT_FALSE(result.HasError());
EXPECT_FALSE(result.GetSettings()->empty());
- frontend_.reset(new ExtensionSettingsFrontend(temp_dir_.path()));
+ frontend_.reset(new ExtensionSettingsFrontend(profile_.get()));
GetBackend(&backend);
storage = backend->GetStorage(id);

Powered by Google App Engine
This is Rietveld 408576698