chrome/browser/extensions/extension_settings_frontend_unittest.cc - Issue 8177022: Add onChanged events to the extension settings API, both from sync and between

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_settings_frontend_unittest.cc

Issue 8177022: Add onChanged events to the extension settings API, both from sync and between (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_settings_frontend.cc ('K') | « chrome/browser/extensions/extension_settings_frontend.cc ('k') | chrome/browser/extensions/extension_settings_leveldb_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_settings_frontend_unittest.cc

diff --git a/chrome/browser/extensions/extension_settings_frontend_unittest.cc b/chrome/browser/extensions/extension_settings_frontend_unittest.cc

index 06d774db9b185e45ed9e110075ea41bb3f4ea16d..0d638704df10ac81f646299b1b240ee87773acdb 100644

--- a/chrome/browser/extensions/extension_settings_frontend_unittest.cc

+++ b/chrome/browser/extensions/extension_settings_frontend_unittest.cc

@@ -26,13 +26,13 @@ class ExtensionSettingsFrontendTest : public testing::Test {

virtual void SetUp() OVERRIDE {

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

- frontend_.reset(new ExtensionSettingsFrontend(temp_dir_.path()));

profile_.reset(new TestingProfile(temp_dir_.path()));

+ frontend_.reset(new ExtensionSettingsFrontend(profile_.get()));

}

virtual void TearDown() OVERRIDE {

- profile_.reset();

frontend_.reset();

+ profile_.reset();

}

protected:

@@ -48,8 +48,8 @@ class ExtensionSettingsFrontendTest : public testing::Test {

}

ScopedTempDir temp_dir_;

- scoped_ptr<ExtensionSettingsFrontend> frontend_;

scoped_ptr<TestingProfile> profile_;

+ scoped_ptr<ExtensionSettingsFrontend> frontend_;

private:

// Intended as a ExtensionSettingsFrontend::BackendCallback from GetBackend.

@@ -80,7 +80,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsPreservedAcrossReconstruction) {

ASSERT_FALSE(result.HasError());

EXPECT_FALSE(result.GetSettings()->empty());

- frontend_.reset(new ExtensionSettingsFrontend(temp_dir_.path()));

+ frontend_.reset(new ExtensionSettingsFrontend(profile_.get()));

GetBackend(&backend);

storage = backend->GetStorage(id);