Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2805)

Unified Diff: chrome/browser/extensions/extension_settings_observer.h

Issue 8177022: Add onChanged events to the extension settings API, both from sync and between (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_settings_observer.h
diff --git a/chrome/browser/extensions/extension_settings_observer.h b/chrome/browser/extensions/extension_settings_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..4fb6e704545f4f94e7f30f08c07905b8bca3520b
--- /dev/null
+++ b/chrome/browser/extensions/extension_settings_observer.h
@@ -0,0 +1,56 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_OBSERVER_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_OBSERVER_H_
+#pragma once
+
+#include "base/values.h"
+
+class Profile;
+
+// Interface for classes that listen to changes to extension settings.
+class ExtensionSettingsObserver {
+ public:
+ // A list of setting changes. Use this class when building the event value,
+ // then pass the result of |GetEventJson| into |OnSettingsChanged|.
+ class ChangeList {
+ public:
+ ChangeList();
+ ~ChangeList();
+
+ // Appends a change for a setting.
+ void AppendChange(
+ const std::string& key,
+ // Ownership taken. May be NULL to imply there is no old value.
+ Value* old_value,
+ // Ownership taken. May be NULL to imply there is no new value.
+ Value* new_value);
+
+ // Gets the JSON serialization of the event.
+ std::string GetEventJson() const;
+
+ private:
+ ListValue changes_;
+ };
+
+ // Called when a list of settings have changed for an extension.
+ //
+ // |profile| is the profile of the event originator, or NULL if the event
+ // didn't originate from a background page. This is so that events can avoid
+ // being sent back to the background page which made the change. When the
+ // settings API is exposed to content scripts, this will need to be changed.
+ //
+ // |event_json| is the JSON serialization of the event to be passed directly
+ // to the onChanged listeners of the settings API.
+ virtual void OnSettingsChanged(
+ Profile* profile,
+ const std::string& extension_id,
+ const std::string& event_json) = 0;
+
+ protected:
+ virtual ~ExtensionSettingsObserver();
+};
+
+#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SETTINGS_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698