chrome/browser/extensions/extension_settings_storage_cache.cc - Issue 8177022: Add onChanged events to the extension settings API, both from sync and between

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_settings_storage_cache.cc

Issue 8177022: Add onChanged events to the extension settings API, both from sync and between (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_settings_storage.h ('K') | « chrome/browser/extensions/extension_settings_storage.cc ('k') | chrome/browser/extensions/extension_settings_storage_unittest.h » ('j') | chrome/browser/extensions/syncable_extension_settings_storage.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_settings_storage_cache.cc

diff --git a/chrome/browser/extensions/extension_settings_storage_cache.cc b/chrome/browser/extensions/extension_settings_storage_cache.cc

index f20f068f9b7dfbd1f4bcfa7d65ea74195ef1042a..4ae97a58186cbd04e5ce97e79461b32cd7c50cfb 100644

--- a/chrome/browser/extensions/extension_settings_storage_cache.cc

+++ b/chrome/browser/extensions/extension_settings_storage_cache.cc

@@ -15,7 +15,7 @@ ExtensionSettingsStorage::Result ExtensionSettingsStorageCache::Get(

if (GetFromCache(key, &value)) {

DictionaryValue* settings = new DictionaryValue();

settings->SetWithoutPathExpansion(key, value);

- return Result(settings, NULL);

+ return Result(settings, NULL, NULL);

}

Result result = delegate_->Get(key);

@@ -43,7 +43,7 @@ ExtensionSettingsStorage::Result ExtensionSettingsStorageCache::Get(

}

if (missing_keys.empty()) {

- return Result(from_cache.release(), NULL);

+ return Result(from_cache.release(), NULL, NULL);

}

Result result = delegate_->Get(keys);