Adding VideoCaptureDevice for Mac.

media/video/capture/mac/video_capture_device_mac_qtkit.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// VideoCaptureDeviceMacQTKit implements all QTKit related code for
+// communicating with a QTKit capture device.
+
+#ifndef MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_QTKIT_H_
+#define MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_QTKIT_H_
+
+#import <Foundation/Foundation.h>
+
+#include "media/video/capture/mac/video_capture_device_mac.h"
+#include "media/video/capture/video_capture_device.h"

[dmac, 2011/10/07 17:38:55]

do you need these includes? All I can see needing is a declaration of 

namespace media {
class VideoCaptureDeviceMac;
}

[mflodman_chromium_OOO, 2011/10/10 12:56:52]

Done.

+
+@class QTCaptureDecompressedVideoOutput;
+@class QTCaptureDeviceInput;
+@class QTCaptureSession;
+
+@interface VideoCaptureDeviceMacQTKit : NSObject {
+ @private
+  // Settings.
+  int frameRate_;
+  int frameWidth_;
+  int frameHeight_;
+
+  media::VideoCaptureDeviceMac *frameReceiver_;
+
+  // QTKit variables.
+  QTCaptureSession *captureSession_;
+  QTCaptureDeviceInput *captureDeviceInput_;

[dmac, 2011/10/07 17:38:55]

any reason for retaining the input and the output instead of querying the
session for them when you need them?

[mflodman_chromium_OOO, 2011/10/10 12:56:52]

input gets disconnected in 'Stop', to avoid a possible hang, hence kept as
member so we can connect if calling start again for the same device.

The main reason for having output as a member was to simplify the code. Changed
now according to your suggestion + autorelease to simplify dealloc and
setCaptureDevice(nil).

[dmac, 2011/10/11 00:25:47]

Done.

[dmac, 2011/10/11 00:25:47]

What hang are you referring to?

+  QTCaptureDecompressedVideoOutput *captureDecompressedOutput_;
+}
+
+// Gets available devices.
++ (NSArray *)deviceNames;

[dmac, 2011/10/07 17:38:55]

what is this returning in the NSArray? Names? or Strings? Might be worthwhile
putting in the comment.

[mflodman_chromium_OOO, 2011/10/10 12:56:52]

Added a comment, but I'll change this to return two arrays of device names and
device ids instead.

[dmac, 2011/10/11 00:25:47]

Done.

+
+// Registers a receiver for the captured frames.
+- (void)setFrameReceiver:(media::VideoCaptureDeviceMac *)frameReceiver;
+
+// Sets which capture device to use. Returns YES on sucess, NO otherwise.
+- (BOOL)setCaptureDevice:(NSString *)deviceId;
+
+// Configures the capture properties.
+- (BOOL)setCaptureCapabilities:(int)height:(int)width:(int)frameRate;

[dmac, 2011/10/07 17:38:55]

actually, this should be:

- (BOOL)setCaptureHeight:(int)height width:(int)width frameRate:(int)frameRate;

[mflodman_chromium_OOO, 2011/10/10 12:56:52]

Done.

+
+// Start video capturing. Returns YES on sucess, NO otherwise.
+- (BOOL)startCapture;
+
+// Stops video capturing.
+- (void)stopCapture;
+
+@end
+
+#endif  // MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_QTKIT_H_