Adding VideoCaptureDevice for Mac.

media/video/capture/video_capture_device_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
+#include "base/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/thread.h"
 #include "media/video/capture/fake_video_capture_device.h"
 #include "media/video/capture/video_capture_device.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if defined(OS_MACOSX)
+// The camera is 'locked' by the application once started on Mac OS X, not when
+// allocated as for Windows and Linux, and this test case will fail.
+#define MAYBE_AllocateSameCameraTwice DISABLED_AllocateSameCameraTwice
+#else
+#define MAYBE_AllocateSameCameraTwice AllocateSameCameraTwice
+#endif
+
+#if defined(OS_MACOSX)
+// Mac/QTKit will always give you the size you ask for and this case will fail.
+#define MAYBE_AllocateBadSize DISABLED_AllocateBadSize
+#else
+#define MAYBE_AllocateBadSize AllocateBadSize
+#endif
+
 using ::testing::_;
 using ::testing::AnyNumber;
 using ::testing::Return;
 using ::testing::AtLeast;
 
 namespace media {
 
-class MockFrameObserver: public media::VideoCaptureDevice::EventHandler {
+class MockFrameObserver : public media::VideoCaptureDevice::EventHandler {
  public:
   MOCK_METHOD0(OnErr, void());
   MOCK_METHOD3(OnFrameInfo, void(int width, int height, int frame_rate));
 
   explicit MockFrameObserver(base::WaitableEvent* wait_event)
      : wait_event_(wait_event) {}
 
   virtual void OnError() OVERRIDE {
     OnErr();
   }
 
   virtual void OnFrameInfo(
       const VideoCaptureDevice::Capability& info) OVERRIDE {
     OnFrameInfo(info.width, info.height, info.frame_rate);
   }
 
   virtual void OnIncomingCapturedFrame(const uint8* data, int length,
                                        base::Time timestamp) OVERRIDE {
     wait_event_->Signal();
   }
 
  private:
   base::WaitableEvent* wait_event_;
 };
 
 class VideoCaptureDeviceTest : public testing::Test {
  public:
   VideoCaptureDeviceTest(): wait_event_(false, false) { }
 
+  void PostQuitTask() {
+    // Give the camera 5s to start.
+    const int quit_task_wait_time_ms = 5000;

[dmac, 2011/10/17 17:02:29]

don't use a fixed constant here. Use one of the values from TestTimeouts because
when running under valgrind things can run WAAAY slower than you expect.

Is there anyway to get a callback when the camera is ready?

[mflodman_chromium_OOO, 2011/10/17 18:40:38]

Ok, changed to your original proposal. It will take quite some time to run the
test, but I guess it's the only way to make sure, for example, Valgrind has
enough time. As you said.

I'll keep searching for better ways, but I have none right now.

+    loop_->PostDelayedTask(FROM_HERE, new MessageLoop::QuitTask,
+                           quit_task_wait_time_ms);
+    loop_->Run();
+  }
+
  protected:
   virtual void SetUp() {
     frame_observer_.reset(new MockFrameObserver(&wait_event_));
+    loop_.reset(new MessageLoopForUI());
   }
 
   virtual void TearDown() {
   }
 
   base::WaitableEvent wait_event_;
   scoped_ptr<MockFrameObserver> frame_observer_;
   VideoCaptureDevice::Names names_;
+  scoped_ptr<MessageLoop> loop_;
 };
 
 TEST_F(VideoCaptureDeviceTest, OpenInvalidDevice) {
   VideoCaptureDevice::Name device_name;
   device_name.device_name = "jibberish";
   device_name.unique_id = "jibberish";
   VideoCaptureDevice* device = VideoCaptureDevice::Create(device_name);
   EXPECT_TRUE(device == NULL);
 }
 
@@ skipping 10 matching lines @@
 
   // Get info about the new resolution.
   EXPECT_CALL(*frame_observer_, OnFrameInfo(640, 480, 30))
       .Times(1);
 
   EXPECT_CALL(*frame_observer_, OnErr())
       .Times(0);
 
   device->Allocate(640, 480, 30, frame_observer_.get());
   device->Start();
-  // Wait for 3s or for captured frame.
+  // Get captured video frames.
+  PostQuitTask();
   EXPECT_TRUE(wait_event_.TimedWait(base::TimeDelta::FromMilliseconds(
       TestTimeouts::action_max_timeout_ms())));
   device->Stop();
   device->DeAllocate();
 }
 
 TEST_F(VideoCaptureDeviceTest, Capture720p) {
   VideoCaptureDevice::GetDeviceNames(&names_);
   if (!names_.size()) {
     LOG(WARNING) << "No camera available. Exiting test.";
     return;
   }
 
   scoped_ptr<VideoCaptureDevice> device(
       VideoCaptureDevice::Create(names_.front()));
   ASSERT_FALSE(device.get() == NULL);
 
   // Get info about the new resolution.
   // We don't care about the resulting resolution or frame rate as it might
   // be different from one machine to the next.
   EXPECT_CALL(*frame_observer_, OnFrameInfo(_, _, _))
       .Times(1);
 
   EXPECT_CALL(*frame_observer_, OnErr())
       .Times(0);
 
   device->Allocate(1280, 720, 30, frame_observer_.get());
   device->Start();
   // Get captured video frames.
+  PostQuitTask();
   EXPECT_TRUE(wait_event_.TimedWait(base::TimeDelta::FromMilliseconds(
       TestTimeouts::action_max_timeout_ms())));
   device->Stop();
   device->DeAllocate();
 }
 
-TEST_F(VideoCaptureDeviceTest, AllocateSameCameraTwice) {
+TEST_F(VideoCaptureDeviceTest, MAYBE_AllocateSameCameraTwice) {
   VideoCaptureDevice::GetDeviceNames(&names_);
   if (!names_.size()) {
     LOG(WARNING) << "No camera available. Exiting test.";
     return;
   }
   scoped_ptr<VideoCaptureDevice> device1(
       VideoCaptureDevice::Create(names_.front()));
   ASSERT_TRUE(device1.get() != NULL);
 
   scoped_ptr<VideoCaptureDevice> device2(
       VideoCaptureDevice::Create(names_.front()));
   ASSERT_TRUE(device2.get() != NULL);
 
   // 1. Get info about the new resolution on the first allocated camera
   EXPECT_CALL(*frame_observer_, OnFrameInfo(640, 480, 30));
 
   device1->Allocate(640, 480, 30, frame_observer_.get());
 
   // 2. Error when trying to allocate the same camera again.
   EXPECT_CALL(*frame_observer_, OnErr());
   device2->Allocate(640, 480, 30, frame_observer_.get());
 
   device1->DeAllocate();
   device2->DeAllocate();
 }
 
-TEST_F(VideoCaptureDeviceTest, AllocateBadSize) {
+TEST_F(VideoCaptureDeviceTest, MAYBE_AllocateBadSize) {
   VideoCaptureDevice::GetDeviceNames(&names_);
   if (!names_.size()) {
     LOG(WARNING) << "No camera available. Exiting test.";
     return;
   }
   scoped_ptr<VideoCaptureDevice> device(
       VideoCaptureDevice::Create(names_.front()));
   ASSERT_TRUE(device.get() != NULL);
 
   EXPECT_CALL(*frame_observer_, OnErr())
@@ skipping 26 matching lines @@
   device->Allocate(640, 480, 30, frame_observer_.get());
   device->Start();
   // Nothing shall happen.
   device->Allocate(1280, 1024, 30, frame_observer_.get());
   device->DeAllocate();
   // Allocate new size 320, 240
   device->Allocate(320, 240, 30, frame_observer_.get());
 
   device->Start();
   // Get captured video frames.
+  PostQuitTask();
   EXPECT_TRUE(wait_event_.TimedWait(base::TimeDelta::FromMilliseconds(

[dmac, 2011/10/17 17:02:29]

do you need the TimedWait and the PostQuitTask?

[mflodman_chromium_OOO, 2011/10/17 18:40:38]

PostQuitTask is needed since it takes care of the RunLoop and the event is used
to make sure a frame has been received and the test passed. After PostQuitTask,
the event should fire right away and it won't introduce any more wait time. If
the test passes as it should that is. I can set the event timeout to a smaller
value, like action_timeout_value().

       TestTimeouts::action_max_timeout_ms())));
   device->Stop();
   device->DeAllocate();
 }
 
 TEST_F(VideoCaptureDeviceTest, DeAllocateCameraWhileRunning) {
   VideoCaptureDevice::GetDeviceNames(&names_);
   if (!names_.size()) {
     LOG(WARNING) << "No camera available. Exiting test.";
     return;
   }
   scoped_ptr<VideoCaptureDevice> device(
       VideoCaptureDevice::Create(names_.front()));
   ASSERT_TRUE(device.get() != NULL);
 
   EXPECT_CALL(*frame_observer_, OnErr())
       .Times(0);
   // Get info about the new resolution.
   EXPECT_CALL(*frame_observer_, OnFrameInfo(640, 480, 30));
 
   device->Allocate(640, 480, 30, frame_observer_.get());
 
   device->Start();
   // Get captured video frames.
+  PostQuitTask();
   EXPECT_TRUE(wait_event_.TimedWait(base::TimeDelta::FromMilliseconds(
       TestTimeouts::action_max_timeout_ms())));
   device->DeAllocate();
 }
 
 TEST_F(VideoCaptureDeviceTest, TestFakeCapture) {
   VideoCaptureDevice::Names names;
 
   FakeVideoCaptureDevice::GetDeviceNames(&names);
 
@@ skipping 13 matching lines @@
   device->Allocate(640, 480, 30, frame_observer_.get());
 
   device->Start();
   EXPECT_TRUE(wait_event_.TimedWait(base::TimeDelta::FromMilliseconds(
       TestTimeouts::action_max_timeout_ms())));
   device->Stop();
   device->DeAllocate();
 }
 
 };  // namespace media