Adding VideoCaptureDevice for Mac.

media/video/capture/mac/video_capture_device_mac_qtkit.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// VideoCaptureDeviceMacQTKit implements all QTKit related code for
+// communicating with a QTKit capture device.
+
+#ifndef MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_QTKIT_H_
+#define MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_QTKIT_H_
+

[dmac, 2011/10/06 23:42:04]

do you need all these imports, or can you forward declare everything? I think
the only import you should need is Foundation/Foundation.h

[mflodman_chromium_OOO, 2011/10/07 13:03:51]

Done.

+#import <QTKit/QTKit.h>
+
+#include "media/video/capture/mac/video_capture_device_mac.h"
+#include "media/video/capture/video_capture_device.h"
+
+@interface VideoCaptureDeviceMacQTKit : NSObject{

[dmac, 2011/10/06 23:42:04]

space between NSObject and {

[mflodman_chromium_OOO, 2011/10/07 13:03:51]

Done.

+ @private
+  // Settings.
+  int frameRate_;
+  int frameWidth_;
+  int frameHeight_;
+
+  media::VideoCaptureDeviceMac* frameReceiver_;
+
+  // QTKit variables.
+  QTCaptureSession* captureSession_;
+  QTCaptureDeviceInput* captureDeviceInput_;
+  QTCaptureDecompressedVideoOutput* captureDecompressedOutput_;
+
+  NSAutoreleasePool* pool_;
+}
+
+// Gets available devices.

[dmac, 2011/10/06 23:42:04]

Normally you would return an autoreleased NSArray. I'm not quite sure what you
expect to happen here...

[mflodman_chromium_OOO, 2011/10/07 13:03:51]

Done.
I'll also look at changing this one to remove all QT* code outside of this
class.

++ (void)deviceNames:(NSArray*)deviceNames;
+
+// Registers a receiver for the captured frames.
+- (void)registerReceiver:(media::VideoCaptureDeviceMac*)frameReceiver;
+
+// Sets which capture device to use. Returns YES on sucess, NO otherwise.
+- (BOOL)setCaptureDevice:(const char*)name;

[dmac, 2011/10/06 23:42:04]

why a const char* instaed of an NSString?

Also, I would only have one interface

- (BOOL)setCaptureDevice:(NSString *) instead of set and remove. If you pass in
nil it would be equivalent to your "remove" at this point. add and remove imply
that you allow more than one capture device to be attached.

[mflodman_chromium_OOO, 2011/10/07 13:03:51]

Changed to NSString*, nil will remove the device and removeCaptureDevice is
removed.
I also changed to use the device id instead of name, to be able to set different
devices with the same name.

+
+// Removes the set capture device.
+- (void)removeCaptureDevice;
+
+// Configures the capture properties.
+- (BOOL)setCaptureHeight:(int)height
+                AndWidth:(int)width

[dmac, 2011/10/06 23:42:04]

lowercase in objc param names, and we don't use "and" in objc methods.

so 

setCaptureHeight:width:framerate:

are you sure you don't want fractional framerates?

[mflodman_chromium_OOO, 2011/10/07 13:03:51]

Changed. Not used to this, so I hope the change is correct...

We are using int elsewhere Chromium video capture, so I'll keep it as an int.
I'll bring that up for discussion with the others though.

+            AndFrameRate:(int)frameRate;
+
+// Start video capturing. Returns YES on sucess, NO otherwise.
+- (BOOL)startCapture;
+
+// Stops video capturing.
+- (void)stopCapture;
+
+@end
+
+#endif  // MEDIA_VIDEO_CAPTURE_MAC_VIDEO_CAPTURE_DEVICE_MAC_QTKIT_H_