Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4599)

Unified Diff: chrome/browser/resources/options/extension_list.js

Issue 8176001: Warn user in case extension delays network traffic too much. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Merged with ToT Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/extension_list.js
diff --git a/chrome/browser/resources/options/extension_list.js b/chrome/browser/resources/options/extension_list.js
index 0e852eb862b2c06a5729fa202037f5f4f84e2a50..d4c71217f66cefe612668cf86ef120a12e140228 100644
--- a/chrome/browser/resources/options/extension_list.js
+++ b/chrome/browser/resources/options/extension_list.js
@@ -239,6 +239,27 @@ cr.define('options', function() {
vbox.appendChild(link);
}
+ if (extension.warnings.length > 0) {
+ var warningsDiv = this.ownerDocument.createElement('div');
+ warningsDiv.classList.add('extension-warnings');
+
+ var warningsHeader = this.ownerDocument.createElement('span');
+ warningsHeader.classList.add('extension-warnings-title');
+ warningsHeader.textContent =
+ localStrings.getString('extensionSettingsWarningsTitle');
+ warningsDiv.appendChild(warningsHeader);
+
+ var warningList = this.ownerDocument.createElement('ul');
+ for (var j = 0; j < extension.warnings.length; ++j) {
+ var warningEntry = this.ownerDocument.createElement('li');
+ warningEntry.textContent = extension.warnings[j];
+ warningList.appendChild(warningEntry);
+ }
+ warningsDiv.appendChild(warningList);
+
+ vbox.appendChild(warningsDiv);
+ }
+
// And now the details section that is normally hidden.
var details = this.ownerDocument.createElement('div');
details.classList.add('vbox');
@@ -711,4 +732,4 @@ cr.define('options', function() {
return {
ExtensionsList: ExtensionsList
};
-});
+});

Powered by Google App Engine
This is Rietveld 408576698