Warn user in case extension delays network traffic too much.

chrome/browser/resources/options/extension_list.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   'use strict';
 
   /**
    * A lookup helper function to find the first node that has an id (starting
    * at |node| and going up the parent chain).
@@ skipping 221 matching lines @@
         // Then the optional Visit Website link.
         if (extension.homepageUrl) {
           var link = this.ownerDocument.createElement('a');
           link.classList.add('extension-links-trailing');
           link.textContent =
               localStrings.getString('extensionSettingsVisitWebsite');
           link.href = extension.homepageUrl;
           vbox.appendChild(link);
         }
 
+        if (extension.warnings.length > 0) {

[Finnur, 2011/10/10 10:02:39]

I guess this is a question for Glen...
Was the intent here for this to be always visible (whether the details section
is expanded or not)?

[battre, 2011/10/10 13:16:36]

This was my intent: Always show it if and only if there is a warning. The
warning should be an exception. In case there is a warning it should be visible.

+          var warningsDiv = this.ownerDocument.createElement('div');
+          warningsDiv.classList.add('extension-warnings');

[Finnur, 2011/10/10 09:59:24]

nit: You use plural here (warnings) but singular for all style names below (I
think I'd prefer singular).

[battre, 2011/10/10 13:16:36]

Given the confusion from the comment below, I have chosen to make the style and
the div name plural. It is one header for all warning*s*.

+
+          var warningHeader = this.ownerDocument.createElement('span');
+          warningHeader.classList.add('extension-warning-title');
+          warningHeader.textContent =
+              localStrings.getString('extensionSettingsWarningsTitle');
+          warningsDiv.appendChild(warningHeader);
+
+          var warningList = this.ownerDocument.createElement('ul');
+          for (var j = 0; j < extension.warnings.length; ++j) {
+            var warningEntry = this.ownerDocument.createElement('li');
+            warningEntry.textContent = extension.warnings[j];
+            warningList.appendChild(warningEntry);

[Finnur, 2011/10/10 09:59:24]

For non-network-slowdown warnings this will look weird, since it will be
'Warning:' heading only and no warning text.

[battre, 2011/10/10 13:16:36]

I am not sure I understand this. This is the reason for the if-statement in line
242. If there are any warnings, we see "Warning:" followed by a bullet list of
all warnings. If there are no warnings, we don't see the "Warning:" caption.

There will be other warnings types in the future (conflicting modifications to
network requests it the next on my list). These warnings will also have textual
descriptions.

[Finnur, 2011/10/10 15:06:56]

Ignore this comment, addressed elsewhere.

On 2011/10/10 13:16:36, battre wrote:

+          }
+          warningsDiv.appendChild(warningList);
+
+          vbox.appendChild(warningsDiv);
+        }
+
         // And now the details section that is normally hidden.
         var details = this.ownerDocument.createElement('div');
         details.classList.add('vbox');
         vbox.appendChild(details);
 
         this.decorateDetailsSection_(details, extension, expanded, butterbar);
 
         // And on the right of the details we have the Enable/Enabled checkbox.
         div = this.ownerDocument.createElement('div');
         hbox.appendChild(div);
@@ skipping 452 matching lines @@
             String(extension.views[i].renderViewId)
           ]);
         }
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
-});
+});