Warn user in case extension delays network traffic too much.

chrome/browser/extensions/extension_warning_set_unittest.cc

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_warning_set.h"
+
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ExtensionglobalError;
+
+namespace {
+
+class MockExtensionWarningSet : public ExtensionWarningSet {
+ public:
+  MockExtensionWarningSet() : ExtensionWarningSet(NULL) {
+    ON_CALL(*this, ActivateBadge()).WillByDefault(
+        testing::Invoke(this, &MockExtensionWarningSet::ActivateBadgeImpl));
+    ON_CALL(*this, DeactivateBadge()).WillByDefault(
+        testing::Invoke(this, &MockExtensionWarningSet::DeactivateBadgeImpl));
+  }
+  virtual ~MockExtensionWarningSet() {}
+
+  MOCK_METHOD0(NotifyWarningsChanged, void());
+  MOCK_METHOD0(ActivateBadge, void());
+  MOCK_METHOD0(DeactivateBadge, void());
+
+  void ActivateBadgeImpl() {
+    // Just fill the value so that we see that something would be there
+    // in a non-mocked execution.
+    extension_global_error_ = reinterpret_cast<ExtensionGlobalError*>(1);
+  }
+  void DeactivateBadgeImpl() {
+    extension_global_error_ = NULL;
+  }
+};
+
+const char* ext1_id = "extension1";
+const char* ext2_id = "extension2";
+
+}  // namespace
+
+// Check that inserting a warning triggers notifications, whereas inserting
+// the same warning again is silent.
+TEST(ExtensionWarningSet, SetWarning) {
+  MockExtensionWarningSet warnings;
+  ExtensionWarning warning(ExtensionWarning::kNetworkDelay, ext1_id);
+
+  // Insert warning for the first time.
+  EXPECT_CALL(warnings, NotifyWarningsChanged());
+  EXPECT_CALL(warnings, ActivateBadge());
+  warnings.SetWarning(warning);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Second insertion of same warning does not trigger anything.
+  warnings.SetWarning(warning);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+}
+
+// Check that ClearWarnings deletes exaclty the specified warnings and

[Matt Perry, 2011/10/07 19:18:38]

typo: exactly

[battre, 2011/10/10 13:16:36]

Done.

+// triggers notifications where appropriate.
+TEST(ExtensionWarningSet, ClearWarnings) {
+  MockExtensionWarningSet warnings;
+  ExtensionWarning warning1(ExtensionWarning::kNetworkDelay, ext1_id);
+  // TODO(battre): Replace kInvalid with something else once we have additional
+  // warning types.
+  ExtensionWarning warning2(ExtensionWarning::kInvalid, ext2_id);
+
+  // Insert two unique warnings.
+  EXPECT_CALL(warnings, NotifyWarningsChanged()).Times(2);
+  EXPECT_CALL(warnings, ActivateBadge()).Times(1);
+  warnings.SetWarning(warning1);
+  warnings.SetWarning(warning2);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Remove the one warning and check that the badge remains.
+  EXPECT_CALL(warnings, NotifyWarningsChanged());
+  std::set<ExtensionWarning::WarningType> to_clear;
+  to_clear.insert(ExtensionWarning::kInvalid);
+  warnings.ClearWarnings(to_clear);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Check that the correct warnings appear in |warnings|.
+  std::set<ExtensionWarning::WarningType> existing_warnings;
+  warnings.GetWarningsAffectingExtension(ext1_id, &existing_warnings);
+  EXPECT_EQ(1u, existing_warnings.size());
+  warnings.GetWarningsAffectingExtension(ext2_id, &existing_warnings);
+  EXPECT_EQ(0u, existing_warnings.size());
+
+  // Remove the other one warning and check that badge disappears.
+  EXPECT_CALL(warnings, NotifyWarningsChanged());
+  EXPECT_CALL(warnings, DeactivateBadge());
+  to_clear.insert(ExtensionWarning::kNetworkDelay);
+  warnings.ClearWarnings(to_clear);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Check that not warnings remain.
+  warnings.GetWarningsAffectingExtension(ext1_id, &existing_warnings);
+  EXPECT_EQ(0u, existing_warnings.size());
+  warnings.GetWarningsAffectingExtension(ext2_id, &existing_warnings);
+  EXPECT_EQ(0u, existing_warnings.size());
+}
+
+// Check that no badge appears if it has been suppressed for a specific
+// warning.
+TEST(ExtensionWarningSet, SuppressBadgeForCurrentWarnings) {
+  MockExtensionWarningSet warnings;
+  ExtensionWarning warning1(ExtensionWarning::kNetworkDelay, ext1_id);
+  // TODO(battre): Replace kInvalid with something else once we have additional
+  // warning types.
+  ExtensionWarning warning2(ExtensionWarning::kInvalid, ext2_id);
+
+  // Insert first warning.
+  EXPECT_CALL(warnings, NotifyWarningsChanged());
+  EXPECT_CALL(warnings, ActivateBadge());
+  warnings.SetWarning(warning1);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Suppress first warning.
+  EXPECT_CALL(warnings, DeactivateBadge());
+  warnings.SuppressBadgeForCurrentWarnings();
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Simulate deinstallation of extension.
+  std::set<ExtensionWarning::WarningType> to_clear;
+  warnings.GetWarningsAffectingExtension(ext1_id, &to_clear);
+  EXPECT_CALL(warnings, NotifyWarningsChanged());
+  warnings.ClearWarnings(to_clear);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Set first warning again and verify that not badge is shown this time.
+  EXPECT_CALL(warnings, NotifyWarningsChanged());
+  warnings.SetWarning(warning1);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+
+  // Set second warning and verify that it shows a badge.
+  EXPECT_CALL(warnings, NotifyWarningsChanged());
+  EXPECT_CALL(warnings, ActivateBadge());
+  warnings.SetWarning(warning2);
+  testing::Mock::VerifyAndClearExpectations(&warnings);
+}