Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 8175009: Eliminate a timed wait from ExportedObject::HandleMessage(). (Closed)

Created:
9 years, 2 months ago by satorux1
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Eliminate a timed wait from ExportedObject::HandleMessage(). Previouslly, we blocked in D-Bus thread until the method call is handled in the UI thread. Turned out this was a bad idea, and caused a crash when the UI thread is hanging (crosbug.com/21341). This patch will eliminate the timed wait and incoming methods will be handled completely asynchronously. BUG=chromium-os:21341 TEST=run dbus_unittests under valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -44 lines) Patch
M dbus/bus.h View 1 chunk +3 lines, -0 lines 0 comments Download
M dbus/bus.cc View 1 chunk +0 lines, -1 line 0 comments Download
M dbus/exported_object.h View 2 chunks +8 lines, -3 lines 0 comments Download
M dbus/exported_object.cc View 2 chunks +46 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
I think this is a good one. :)
9 years, 2 months ago (2011-10-06 17:56:02 UTC) #1
stevenjb
Agreed. LGTM
9 years, 2 months ago (2011-10-06 21:56:12 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8175009/1
9 years, 2 months ago (2011-10-07 06:12:32 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-07 07:14:07 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/8175009/1
9 years, 2 months ago (2011-10-07 15:01:32 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 16:26:32 UTC) #6
Change committed as 104497

Powered by Google App Engine
This is Rietveld 408576698