Issue 8175005: When "Clear site data on exit" is checked, only pass the private mode flag to Flash.

Issue 8175005: When "Clear site data on exit" is checked, only pass the private mode flag to Flash. (Closed)

Created:
9 years, 2 months ago by Bernhard Bauer

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam, stuartmorgan, erikwright (departed)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

When "Clear site data on exit" is checked, only pass the private mode flag to Flash. BUG=97319 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104507

Patch Set 3 : use constant #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	content/browser/renderer_host/render_message_filter.cc	View	1 2	3 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm with nit http://codereview.chromium.org/8175005/diff/1002/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): http://codereview.chromium.org/8175005/diff/1002/content/browser/renderer_host/render_message_filter.cc#newcode201 content/browser/renderer_host/render_message_filter.cc:201: if (info_.mime_types[i].mime_type == "application/x-shockwave-flash") nit: please ...

9 years, 2 months ago (2011-10-07 16:08:02 UTC) #2

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/8175005/4002

9 years, 2 months ago (2011-10-07 16:13:18 UTC) #3

Bernhard Bauer

http://codereview.chromium.org/8175005/diff/1002/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): http://codereview.chromium.org/8175005/diff/1002/content/browser/renderer_host/render_message_filter.cc#newcode201 content/browser/renderer_host/render_message_filter.cc:201: if (info_.mime_types[i].mime_type == "application/x-shockwave-flash") On 2011/10/07 16:08:02, John Abd-El-Malek ...

9 years, 2 months ago (2011-10-07 16:26:19 UTC) #4

Change committed as 104507

Expand Messages | Collapse Messages