Issue 8175: Fix a problem with the SyncChannel rewrite. DispatchReplies needs to be call...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8175: Fix a problem with the SyncChannel rewrite. DispatchReplies needs to be call... (Closed)

Created:
12 years, 2 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a problem with the SyncChannel rewrite. DispatchReplies needs to be called after the deserializer has been popped. This now happens in the listener thread, so post a task to the IPC thread to do it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3971

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -40 lines)			Patch
	M	chrome/common/ipc_sync_channel.cc	View		5 chunks	+36 lines, -40 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

12 years, 2 months ago (2008-10-25 00:44:52 UTC) #2

OK

can you come up with a test for this case?  can be done in a separate CL.

Expand Messages | Collapse Messages