Issue 8174005: Get Chrome to build & link with USE_AURA on Windows again.

Issue 8174005: Get Chrome to build & link with USE_AURA on Windows again. (Closed)

Created:
9 years, 2 months ago by Ben Goodger (Google)

Modified:
9 years, 2 months ago

Reviewers:
jabdelmalek, jam, commit-bot: I haz the power, Emmanuel Saint-loubert-Bié

CC:
chromium-reviews, tfarina, dpranke+watch-content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Get Chrome to build & link with USE_AURA on Windows again.BUG=noneTEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104382

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -40 lines)			Patch
M	build/common.gypi	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_main.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_win.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/process_singleton.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/process_singleton_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views_win.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/dropdown_bar_host.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/shell_dialogs_aura.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	content/browser/renderer_host/render_message_filter_aura.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/plugin/webplugin_delegate_stub.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/webplugin_delegate_stub.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/plugin/webplugin_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/webplugin_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printed_document_aura.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	views/views.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_delegate_impl.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

jam: content, webkit/plugins saintlou: everything else

9 years, 2 months ago (2011-10-06 18:41:36 UTC) #1

Emmanuel Saint-loubert-Bié

Hi Ben, This CL breaks Linux, see comment below (but then again I broke you ...

9 years, 2 months ago (2011-10-06 19:02:09 UTC) #2

Ben Goodger (Google)

Hi Emmanuel, I updated this so it builds. Also this fixes the compile error James ...

9 years, 2 months ago (2011-10-06 20:39:32 UTC) #3

Emmanuel Saint-loubert-Bié

lgtm Pushing to CQ after talking to Ben.

9 years, 2 months ago (2011-10-06 20:52:53 UTC) #6

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/8174005/2007

9 years, 2 months ago (2011-10-06 20:53:05 UTC) #7

Emmanuel Saint-loubert-Bié

Ben, I landed http://codereview.chromium.org/8159009/ to prevent regressions on Windows and Linux build of Chrome under ...

9 years, 2 months ago (2011-10-06 23:11:02 UTC) #9

Ben Goodger (Google)

9 years, 2 months ago (2011-10-06 23:19:44 UTC) #10

Cool!

-Ben

On Thu, Oct 6, 2011 at 4:10 PM, Emmanuel Saint-loubert <
saintlou@chromium.org> wrote:

>
> Ben, I landed http://codereview.chromium.org/8159009/ to prevent
> regressions on Windows and Linux build of Chrome under Aura.

Expand Messages | Collapse Messages