Issue 8172011: [Mac] Properly show and hide the avatar button for the one-profile case.

Issue 8172011: [Mac] Properly show and hide the avatar button for the one-profile case. (Closed)

Created:
9 years, 2 months ago by Robert Sesek

Modified:
9 years, 2 months ago

Reviewers:
Miranda Callahan, commit-bot: I haz the power, sail

CC:
chromium-reviews, rginda+watch_chromium.org, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] Properly show and hide the avatar button for the one-profile case. This change makes AvatarButton a view controller that is always instantiated by the BrowserWindowController, and whose view is selectively hidden. BUG=99309 TEST=As in bug. Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104380 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=104389 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104490

Patch Set 3 : Fix test #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -289 lines)			Patch
D	chrome/browser/ui/cocoa/browser/avatar_button.h	View		1 chunk	+0 lines, -47 lines	0 comments	Download
D	chrome/browser/ui/cocoa/browser/avatar_button.mm	View		1 chunk	+0 lines, -174 lines	0 comments	Download
A	chrome/browser/ui/cocoa/browser/avatar_button_controller.h	View		1 chunk	+44 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/cocoa/browser/avatar_button_controller.mm	View	1	7 chunks	+60 lines, -33 lines	0 comments	Download
A	chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm	View	1 2	1 chunk	+44 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View		2 chunks	+10 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View		3 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/testing_profile_manager.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sail

LGTM! http://codereview.chromium.org/8172011/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm File chrome/browser/ui/cocoa/browser/avatar_button_controller.mm (right): http://codereview.chromium.org/8172011/diff/1/chrome/browser/ui/cocoa/browser/avatar_button_controller.mm#newcode185 chrome/browser/ui/cocoa/browser/avatar_button_controller.mm:185: // add or remove the avatar button from ...

9 years, 2 months ago (2011-10-06 19:21:14 UTC) #2

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/8172011/14

9 years, 2 months ago (2011-10-06 20:40:47 UTC) #3

Change committed as 104380

Expand Messages | Collapse Messages