Issue 8171013: Support scoped_refptr<> as the object for a method call in base::Bind(). Reduce useless copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8171013: Support scoped_refptr<> as the object for a method call in base::Bind(). Reduce useless copies. (Closed)

Created:
9 years, 2 months ago by awong

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, willchan no longer on Chromium

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, darin (slow to review), akalin, csilv

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Support scoped_refptr<> as the object for a method call in base::Bind(). Reduce useless copies. Patch up an API hole where you can't do base::Bind(&Foo::method, ptr), if ptr is a scoped_refptr. Also modify Unwrap() to remove a couple of unecessary copies for scoped_refptrs, and WeakPtrs<>. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104399

Patch Set 1 #

Patch Set 2 : Fix comment #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	base/bind_helpers.h	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
	M	base/bind_unittest.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

awong

+csilv. FYI, your change shouldn't need the extra io_thraed.get() after this is checked in.

9 years, 2 months ago (2011-10-06 19:26:46 UTC) #2

commit-bot: I haz the power

9 years, 2 months ago (2011-10-06 21:59:11 UTC) #4

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/8171013/3001

Expand Messages | Collapse Messages