Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 8171006: Fix gps.h license issue, by deleting it (Closed)

Created:
9 years, 2 months ago by joth
Modified:
9 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke+watch-content_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix gps.h license issue, by deleting it BUG=98132, 99326 TEST=used gpsfake (from lucid package 2.92) and opened maps.google.com/maps/m Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104481 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104716

Patch Set 1 #

Patch Set 2 : update checklicenses.py #

Total comments: 2

Patch Set 3 : fix content tests #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -772 lines) Patch
M content/browser/geolocation/gps_location_provider_unittest_linux.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
D content/browser/geolocation/libgps_2_38_wrapper_linux.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M content/browser/geolocation/libgps_2_94_wrapper_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/geolocation/libgps_wrapper_linux.h View 5 chunks +0 lines, -6 lines 0 comments Download
M content/browser/geolocation/libgps_wrapper_linux.cc View 5 chunks +14 lines, -33 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/gpsd/README.chromium View 2 chunks +5 lines, -5 lines 0 comments Download
D third_party/gpsd/release-2.38/gps.h View 1 chunk +0 lines, -651 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
joth
9 years, 2 months ago (2011-10-06 16:01:31 UTC) #1
John Knottenbelt
LGTM. One inline comment. http://codereview.chromium.org/8171006/diff/9/content/browser/geolocation/libgps_2_94_wrapper_linux.cc File content/browser/geolocation/libgps_2_94_wrapper_linux.cc (right): http://codereview.chromium.org/8171006/diff/9/content/browser/geolocation/libgps_2_94_wrapper_linux.cc#newcode35 content/browser/geolocation/libgps_2_94_wrapper_linux.cc:35: if (position->accuracy != position->accuracy) { ...
9 years, 2 months ago (2011-10-06 16:26:56 UTC) #2
joth
Thanks +jam & phajdan.jr for OWNER stamping. http://codereview.chromium.org/8171006/diff/9/content/browser/geolocation/libgps_2_94_wrapper_linux.cc File content/browser/geolocation/libgps_2_94_wrapper_linux.cc (right): http://codereview.chromium.org/8171006/diff/9/content/browser/geolocation/libgps_2_94_wrapper_linux.cc#newcode35 content/browser/geolocation/libgps_2_94_wrapper_linux.cc:35: if (position->accuracy ...
9 years, 2 months ago (2011-10-06 19:15:57 UTC) #3
jam
content lgtm
9 years, 2 months ago (2011-10-06 19:22:16 UTC) #4
rharrison
lgtm LGTM
9 years, 2 months ago (2011-10-06 19:28:31 UTC) #5
Paweł Hajdan Jr.
checklicenses LGTM, thanks!
9 years, 2 months ago (2011-10-06 19:31:10 UTC) #6
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/8171006/9
9 years, 2 months ago (2011-10-07 09:36:04 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-07 10:37:19 UTC) #8
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/8171006/9
9 years, 2 months ago (2011-10-07 13:18:31 UTC) #9
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-07 14:23:46 UTC) #10
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/8171006/11001
9 years, 2 months ago (2011-10-10 12:43:59 UTC) #11
commit-bot: I haz the power
9 years, 2 months ago (2011-10-10 15:12:29 UTC) #12
Change committed as 104716

Powered by Google App Engine
This is Rietveld 408576698