Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 8169009: Remove FieldTypeSubGroups from the AutofillType class. (Closed)

Created:
9 years, 2 months ago by Ilya Sherman
Modified:
9 years, 2 months ago
CC:
chromium-reviews, GeorgeY, Ilya Sherman, dyu1, dhollowa
Visibility:
Public.

Description

Remove FieldTypeSubGroups from the AutofillType class. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104583

Patch Set 1 #

Patch Set 2 : Fix tests compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -203 lines) Patch
M chrome/browser/autofill/address.cc View 2 chunks +7 lines, -18 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_profile.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autofill/autofill_type.h View 2 chunks +1 line, -27 lines 0 comments Download
M chrome/browser/autofill/autofill_type.cc View 2 chunks +53 lines, -126 lines 0 comments Download
M chrome/browser/autofill/autofill_type_unittest.cc View 1 1 chunk +2 lines, -10 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/phone_number.cc View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ilya Sherman
9 years, 2 months ago (2011-10-06 05:05:00 UTC) #1
dhollowa
LGTM. Nice cleanup.
9 years, 2 months ago (2011-10-06 20:17:20 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8169009/3001
9 years, 2 months ago (2011-10-06 20:24:22 UTC) #3
commit-bot: I haz the power
Change committed as 104383
9 years, 2 months ago (2011-10-06 23:08:14 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8169009/3001
9 years, 2 months ago (2011-10-07 09:12:23 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-07 10:14:28 UTC) #6
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8169009/3001
9 years, 2 months ago (2011-10-07 11:31:03 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-07 12:32:26 UTC) #8
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8169009/3001
9 years, 2 months ago (2011-10-07 20:57:20 UTC) #9
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 22:37:11 UTC) #10
Change committed as 104583

Powered by Google App Engine
This is Rietveld 408576698