PART4: Removed the owner cache special handling from UserCrosSettingsProvider.

chrome/browser/chromeos/login/signed_settings.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/signed_settings.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 345 matching lines @@
   } else if (prop == kAccountsPrefUsers) {
     em::UserWhitelistProto* whitelist_proto = pol.mutable_user_whitelist();
     whitelist_proto->clear_user_whitelist();
     const base::ListValue& users = static_cast<const base::ListValue&>(value);
     for (base::ListValue::const_iterator i = users.begin();
          i != users.end(); ++i) {
       std::string email;
       if ((*i)->GetAsString(&email))
         whitelist_proto->add_user_whitelist(email.c_str());
     }
+  } else if (prop == kDeviceOwner) {
+    // We don't serialize this one to the policy blob.

[Mattias Nissler (ping if slow), 2011/10/07 13:46:52]

It's actually good to make it a NOTREACHED(), do you know why we had this branch
before?

[pastarmovj, 2011/10/13 12:00:41]

Actually it is not NOTREACHED() it will be called whenever the user calls
CrosSettings.Set(kDeviceOwner, new_powner); which will put it in the local_state
cache it should however not be serialized down to the blob as this is not the
way to set the owner. 
The session_manager does that for us. Actually the cool thing now is that once
the session_manager writes its version of the owner we'll update the cache with
that and thus there is no way that a user can try to trick the browser into
thinking another user is the owner because this will be overwritten on policy
load. 
We don't trust this value for nothing but UI though so not really a security
issue.

   } else {
     NOTREACHED();
   }
   poldata->set_policy_value(pol.SerializeAsString());
 }
 
 void StorePropertyOp::PerformCallback(SignedSettings::ReturnCode code,
                                       bool value) {
   d_->OnSettingsOpCompleted(code, value);
 }
@@ skipping 326 matching lines @@
   sig.assign(sig_ptr, sig_ptr + policy_.policy_data_signature().length());
   service_->StartVerifyAttempt(policy_.policy_data(), sig, this);
 }
 
 void RetrievePolicyOp::PerformCallback(SignedSettings::ReturnCode code,
                                        const em::PolicyFetchResponse& value) {
   d_->OnSettingsOpCompleted(code, value);
 }
 
 }  // namespace chromeos