CrOS - Fix BVT autotest failures due to device concluding it is offline

chrome/browser/chromeos/cros/network_library.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/cros/network_library.h"
 
 #include <algorithm>
 #include <dbus/dbus-glib.h>
 #include <dbus/dbus-gtype-specialized.h>
 #include <glib-object.h>
@@ skipping 4561 matching lines @@
   NetworkDevice* cellular = new NetworkDevice("cellular");
   cellular->type_ = TYPE_CELLULAR;
   cellular->imsi_ = "123456789012345";
   device_map_["cellular"] = cellular;
 
   // Networks
   DeleteNetworks();
 
   ethernet_ = new EthernetNetwork("eth1");
   ethernet_->set_connected(true);
+  // Note: We need exactly one network connected and active, otherwise
+  // browser_tests sometimes conclude we are offline and fail.
+  ethernet_->set_is_active(true);
   AddNetwork(ethernet_);
 
   WifiNetwork* wifi1 = new WifiNetwork("fw1");
   wifi1->set_name("Fake WiFi Connected");
   wifi1->set_strength(90);
   wifi1->set_connected(false);
   wifi1->set_connecting(true);
-  wifi1->set_is_active(true);
   wifi1->set_encryption(SECURITY_NONE);
   wifi1->set_profile_type(PROFILE_SHARED);
   AddNetwork(wifi1);
 
   WifiNetwork* wifi2 = new WifiNetwork("fw2");
   wifi2->set_name("Fake WiFi");
   wifi2->set_strength(70);
   wifi2->set_connected(false);
   wifi2->set_encryption(SECURITY_NONE);
   wifi2->set_profile_type(PROFILE_SHARED);
@@ skipping 33 matching lines @@
   wifi6->set_connected(false);
   AddNetwork(wifi6);
 
   active_wifi_ = wifi1;
 
   CellularNetwork* cellular1 = new CellularNetwork("fc1");
   cellular1->set_name("Fake Cellular");
   cellular1->set_strength(70);
   cellular1->set_connected(false);
   cellular1->set_connecting(true);
-  cellular1->set_is_active(true);
   cellular1->set_activation_state(ACTIVATION_STATE_ACTIVATED);
   cellular1->set_payment_url(std::string("http://www.google.com"));
   cellular1->set_usage_url(std::string("http://www.google.com"));
   cellular1->set_network_technology(NETWORK_TECHNOLOGY_EVDO);
   cellular1->set_roaming_state(ROAMING_STATE_ROAMING);
 
   CellularDataPlan* base_plan = new CellularDataPlan();
   base_plan->plan_name = "Base plan";
   base_plan->plan_type = CELLULAR_DATA_PLAN_METERED_BASE;
   base_plan->plan_data_bytes = 100ll * 1024 * 1024;
@@ skipping 186 matching lines @@
   return impl;
 }
 
 /////////////////////////////////////////////////////////////////////////////
 
 }  // namespace chromeos
 
 // Allows InvokeLater without adding refcounting. This class is a Singleton and
 // won't be deleted until its last InvokeLater is run.
 DISABLE_RUNNABLE_METHOD_REFCOUNT(chromeos::NetworkLibraryImplBase);