Further refactoring, move ImageInfo into Disassembler/DisassemblerWin32X86.

Further refactoring, move ImageInfo into Disassembler/DisassemblerWin32X86.

This means that all PE specific knowledge is now contained in a single class
which leaves us in pretty good shape for supporting ELF 32.

There are still widespread assumptions about being 32 bit, but those can be
addressed at a much later date.

BUG=None
TEST=Unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107260

[dgarrett, 2011-10-06 02:32:48]

I think this is the last of the big refactors...

Most changes remaining are actually ELF related.

[dgarrett, 2011-10-06 17:56:25]

I'm a little less confident that this is the right change to make, but I think
the advantages of having nearly all code related to a single architecture in one
class over-weighs the cost making the disassembler more complicated.

[sra1, 2011-10-14 23:05:59]

LGTM.

http://codereview.chromium.org/8166013/diff/1/courgette/types_win_pe.h
File courgette/types_win_pe.h (right):

http://codereview.chromium.org/8166013/diff/1/courgette/types_win_pe.h#newcode15
courgette/types_win_pe.h:15: typedef uint32 RVA;
This is also typedef-ed in disassembler.h

[dgarrett, 2011-10-25 23:15:17]

http://codereview.chromium.org/8166013/diff/1/courgette/types_win_pe.h
File courgette/types_win_pe.h (right):

http://codereview.chromium.org/8166013/diff/1/courgette/types_win_pe.h#newcode15
courgette/types_win_pe.h:15: typedef uint32 RVA;
On 2011/10/14 23:05:59, sra1 wrote:
> This is also typedef-ed in disassembler.h

Done.

[commit-bot: I haz the power, 2011-10-25 23:15:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgarrett@chromium.org/8166013/11001

[commit-bot: I haz the power, 2011-10-26 00:50:22]

Change committed as 107260