OpenSSL component build fixes.

OpenSSL component build fixes.

BUG=none
TEST=build with component=shared_library use_openssl=1


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104342

[joth, 2011-10-06 08:38:43]

LGTM (but you'll need an OWNER stamp for both; +agl)

[agl, 2011-10-06 14:00:10]

LGTM

(Although I'm not an owner for net/)

[joth, 2011-10-06 14:03:28]

On 6 October 2011 15:00, <agl@chromium.org> wrote:

> LGTM
>
> (Although I'm not an owner for net/)
>
>
I was cross eyed reading that lot then, sorry.

+wtc for another OWNER approval. Thanks.



>
http://codereview.chromium.**org/8166003/<http://codereview.chromium.org/8166...
>

[wtc, 2011-10-06 17:41:07]

LGTM.

mattm: since you are on vacation, I will submit this CL to
the commit queue for you.

http://codereview.chromium.org/8166003/diff/1/net/base/x509_util_openssl.h
File net/base/x509_util_openssl.h (right):

http://codereview.chromium.org/8166003/diff/1/net/base/x509_util_openssl.h#ne...
net/base/x509_util_openssl.h:32: bool NET_EXPORT
ParsePrincipalValueByIndex(X509_NAME* name,

Nit: ParsePrincipalValueByIndex isn't used outside src/net,
so we don't need to export it.  But it's fine to export it
for consistency.

[commit-bot: I haz the power, 2011-10-06 17:41:19]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/8166003/1

[commit-bot: I haz the power, 2011-10-06 19:17:39]

Change committed as 104342