Issue 8165010: Make clone() compatible with ARM's Thumb-2 instruction set. Bug reported and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8165010: Make clone() compatible with ARM's Thumb-2 instruction set. Bug reported and (Closed)

Created:
9 years, 2 months ago by Markus (顧孟勤)

Modified:
9 years, 2 months ago

Reviewers:
Michael Krebs

CC:
chromium-reviews, Markus (顧孟勤)

Base URL:
http://linux-syscall-support.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Make clone() compatible with ARM's Thumb-2 instruction set. Bug reported and fixed by mkrebs@chromium.org Committed: http://code.google.com/p/linux-syscall-support/source/detail?r=7

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	lss/linux_syscall_support.h	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Markus (顧孟勤)

I manually applied your patch, but haven't actually performed any tests (for lack of an ...

9 years, 2 months ago (2011-10-06 02:01:09 UTC) #1

Markus (顧孟勤)

9 years, 2 months ago (2011-10-06 05:36:39 UTC) #3

Committed.

You probably now need to roll forward the DEPS file for your project
(Chrome, breakpad, ...). I'll leave that up to you, as you'll be in the best
position to actually test that it works on ARM.

Let me know, if you need a codereview, though. Or if you need any other
help.

Markus

On Wed, Oct 5, 2011 at 19:32, <mkrebs@chromium.org> wrote:

> lgtm
>
> Thanks!
>
>
>
http://codereview.chromium.**org/8165010/<http://codereview.chromium.org/8165...
>

Expand Messages | Collapse Messages