Stubs for printing under Aura

We will need to support printing under Aura + ChromeOS (and we will have to remove Gtk too).

BUG=97131
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104244

[Emmanuel Saint-loubert-Bié, 2011-10-05 22:23:36]

Hi! Can you please take a look. Thanks!

-- Emmanuel

[kmadhusu, 2011-10-05 22:44:51]

http://codereview.chromium.org/8165004/diff/1/chrome/browser/printing/print_j...
File chrome/browser/printing/print_job_worker.cc (right):

http://codereview.chromium.org/8165004/diff/1/chrome/browser/printing/print_j...
chrome/browser/printing/print_job_worker.cc:63: NOTIMPLEMENTED();
Is there any specific reason for adding this check here (this code is executed
at the end of the printing workflow) rather than adding the code at the very
beginning of the printing workflow (like when the user press ctrl+P etc.,)?

[Lei Zhang, 2011-10-05 23:35:04]

Have you considered implementing a dummy printing_context_aura.cc, instead of
cluttering code with #ifdefs?

[Emmanuel Saint-loubert-Bié, 2011-10-05 23:38:28]

That would be fine too. I am working all over the code and each OWNERS
have their own preferences. I will submit an update.

-- E

On Wed, Oct 5, 2011 at 4:35 PM,  <thestig@chromium.org> wrote:
> Have you considered implementing a dummy printing_context_aura.cc, instead
> of
> cluttering code with #ifdefs?
>
> http://codereview.chromium.org/8165004/
>

[Emmanuel Saint-loubert-Bié, 2011-10-05 23:51:50]

Hi Lei,

I applied your comments. PTAL. Thanks,

-- Emmanuel

[Lei Zhang, 2011-10-05 23:55:58]

http://codereview.chromium.org/8165004/diff/2002/printing/printed_document_au...
File printing/printed_document_aura.cc (right):

http://codereview.chromium.org/8165004/diff/2002/printing/printed_document_au...
printing/printed_document_aura.cc:8: 
It would be good to add a comment here to explain this is a stub and so on.
Ditto for printing_context_aura.cc.

http://codereview.chromium.org/8165004/diff/2002/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/8165004/diff/2002/printing/printing.gyp#newcode57
printing/printing.gyp:57: 'printed_document_aura.cc',
You probably want these files inside a conditional so they only get built in the
configurations you care about.

[Emmanuel Saint-loubert-Bié, 2011-10-06 00:38:52]

Applied your comments I will apply a conditional in the gyp if the trybots fail
(I believe these files should be excluded from rules in common gyp files).

http://codereview.chromium.org/8165004/diff/2002/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/8165004/diff/2002/printing/printing.gyp#newcode57
printing/printing.gyp:57: 'printed_document_aura.cc',
should not be needed due to general eclusion rules, right?

[Lei Zhang, 2011-10-06 00:42:58]

lgtm

http://codereview.chromium.org/8165004/diff/2002/printing/printing.gyp
File printing/printing.gyp (right):

http://codereview.chromium.org/8165004/diff/2002/printing/printing.gyp#newcode57
printing/printing.gyp:57: 'printed_document_aura.cc',
On 2011/10/06 00:38:52, Emmanuel Saint-loubert wrote:
> should not be needed due to general eclusion rules, right?

If there's a general exclusion rule, then that's fine.

[commit-bot: I haz the power, 2011-10-06 03:00:26]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/8165004/1004

[commit-bot: I haz the power, 2011-10-06 04:32:57]

Change committed as 104244