Issue 8163011: PART3: Removed whitelist special ops.

Issue 8163011: PART3: Removed whitelist special ops. (Closed)

Created:
9 years, 2 months ago by pastarmovj

Modified:
9 years, 1 month ago

Reviewers:
Chris Masone, Denis Lagno, Mattias Nissler (ping if slow)

CC:
chromium-reviews, stevenjb, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr., kuan

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Removed whitelist special ops. BUG=chromium-os:14054 TEST=unit_tests:*Signed*, browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111154

Patch Set 2 : Rebased on the new PART2. (I think it should be 100% the same but I'd rather upload it) #

Total comments: 1

Patch Set 3 : Rebased on ToT+[PART1..PART2]. #

Patch Set 4 : Rebased on fixed PART2. #

Patch Set 5 : Rebased on ToT where both previous parts are committed. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -686 lines)			Patch
M	chrome/browser/chromeos/login/mock_signed_settings_helper.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings.h	View	1 2 3 4	2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings.cc	View	1 2 3 4	3 chunks	+0 lines, -290 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings_helper.h	View	1 2 3 4	2 chunks	+0 lines, -19 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings_helper.cc	View	1 2 3 4	3 chunks	+0 lines, -92 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings_helper_unittest.cc	View	1 2 3 4	3 chunks	+15 lines, -53 lines	0 comments	Download
M	chrome/browser/chromeos/login/signed_settings_unittest.cc	View	1 2 3 4	2 chunks	+0 lines, -187 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.h	View	1 2 3 4	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.cc	View	1 2 3 4	1 chunk	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc	View	1 2 3 4	2 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

this looks nice :), just one question. http://codereview.chromium.org/8163011/diff/1/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc File chrome/browser/chromeos/login/signed_settings_helper_unittest.cc (right): http://codereview.chromium.org/8163011/diff/1/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc#newcode156 chrome/browser/chromeos/login/signed_settings_helper_unittest.cc:156: .Times(1) since ...

9 years, 2 months ago (2011-10-07 13:44:49 UTC) #2

pastarmovj

PTAL. Cleaned up this one too and ran it through the testing queue. Again the ...

9 years, 2 months ago (2011-10-13 11:31:38 UTC) #3

Denis Lagno

9 years, 2 months ago (2011-10-14 15:21:59 UTC) #5

lgtm

http://codereview.chromium.org/8163011/diff/9001/chrome/browser/chromeos/cros...
File chrome/browser/chromeos/cros/login_library.cc (right):

http://codereview.chromium.org/8163011/diff/9001/chrome/browser/chromeos/cros...
chrome/browser/chromeos/cros/login_library.cc:176: // DEPRECATED.
nit: it is not a macro to be all-CAPS:)

Expand Messages | Collapse Messages