| OLD | NEW |
| 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 310 results.extend(_CommonChecks(input_api, output_api)) | 310 results.extend(_CommonChecks(input_api, output_api)) |
| 311 # TODO(thestig) temporarily disabled, doesn't work in third_party/ | 311 # TODO(thestig) temporarily disabled, doesn't work in third_party/ |
| 312 #results.extend(input_api.canned_checks.CheckSvnModifiedDirectories( | 312 #results.extend(input_api.canned_checks.CheckSvnModifiedDirectories( |
| 313 # input_api, output_api, sources)) | 313 # input_api, output_api, sources)) |
| 314 # Make sure the tree is 'open'. | 314 # Make sure the tree is 'open'. |
| 315 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 315 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 316 input_api, | 316 input_api, |
| 317 output_api, | 317 output_api, |
| 318 json_url='http://chromium-status.appspot.com/current?format=json')) | 318 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 319 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api, | 319 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api, |
| 320 output_api, 'http://codereview.chromium.org', ('win', 'linux', 'mac'), | 320 output_api, 'http://codereview.chromium.org', |
| 321 'tryserver@chromium.org')) | 321 ('win_rel', 'linux_rel', 'mac_rel'), 'tryserver@chromium.org')) |
| 322 | 322 |
| 323 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 323 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 324 input_api, output_api)) | 324 input_api, output_api)) |
| 325 results.extend(input_api.canned_checks.CheckChangeHasTestField( | 325 results.extend(input_api.canned_checks.CheckChangeHasTestField( |
| 326 input_api, output_api)) | 326 input_api, output_api)) |
| 327 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 327 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 328 input_api, output_api)) | 328 input_api, output_api)) |
| 329 results.extend(_CheckSubversionConfig(input_api, output_api)) | 329 results.extend(_CheckSubversionConfig(input_api, output_api)) |
| 330 return results | 330 return results |
| 331 | 331 |
| 332 | 332 |
| 333 def GetPreferredTrySlaves(project, change): | 333 def GetPreferredTrySlaves(project, change): |
| 334 only_objc_files = all( | 334 only_objc_files = all( |
| 335 f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles()) | 335 f.LocalPath().endswith(('.mm', '.m')) for f in change.AffectedFiles()) |
| 336 if only_objc_files: | 336 if only_objc_files: |
| 337 return ['mac'] | 337 return ['mac_rel'] |
| 338 return ['win', 'linux', 'mac'] | 338 return ['win_rel', 'linux_rel', 'mac_rel'] |
| OLD | NEW |