Fix a bug in dbus::Bus::AddFilterFunction().

Fix a bug in dbus::Bus::AddFilterFunction().

We should not reject the same function if it's associated with different data.

BUG=99258
TEST=adde a unit test and confirmed it passed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104208

[cwolfe, 2011-10-05 22:39:15]

Thanks for the quick fix. Roughly half a nit, but LGTM.

http://codereview.chromium.org/8161005/diff/1/dbus/bus.cc
File dbus/bus.cc (right):

http://codereview.chromium.org/8161005/diff/1/dbus/bus.cc#newcode453
dbus/bus.cc:453: return false;
Do not know our rules for logging pointer-like things. For debug, I tend to cast
them to (void*) so they become unique hex strings.

[satorux1, 2011-10-05 23:04:40]

http://codereview.chromium.org/8161005/diff/1/dbus/bus.cc
File dbus/bus.cc (right):

http://codereview.chromium.org/8161005/diff/1/dbus/bus.cc#newcode453
dbus/bus.cc:453: return false;
On 2011/10/05 22:39:16, cwolfe wrote:
> Do not know our rules for logging pointer-like things. For debug, I tend to
cast
> them to (void*) so they become unique hex strings.

I thought our logging library automatically converted pointers to hex strings,
but I might be wrong.

C-style cast like (void*) is prohibited by the Google C++ style guide. we may
need to use reinterpret_cast for function pointers, but for now. I'd keep the
code as is...