Enable stats_tabe_unittest.cc on OS X.

Enable stats_tabe_unittest.cc on OS X.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4024

[Amanda Walker, 2008-10-27 16:56:16]

http://codereview.chromium.org/8160/diff/207/208
File base/process_util_mac.mm (right):

http://codereview.chromium.org/8160/diff/207/208#newcode16
Line 16: bool wait, ProcessHandle* process_handle) {
It might be simpler (and involve less data copying) to implement this directly
using posix_spawn() instead of an NSTask, since we'd not using any of the other
features of NSTask.

[jeremy, 2008-10-27 18:35:33]

http://codereview.chromium.org/8160/diff/207/208
File base/process_util_mac.mm (right):

http://codereview.chromium.org/8160/diff/207/208#newcode16
Line 16: bool wait, ProcessHandle* process_handle) {
On 2008/10/27 16:56:17, Amanda Walker wrote:
> It might be simpler (and involve less data copying) to implement this directly
> using posix_spawn() instead of an NSTask, since we'd not using any of the
other
> features of NSTask.

Done.

[Amanda Walker, 2008-10-27 18:50:51]

LGTM with one additional simplification.

http://codereview.chromium.org/8160/diff/216/217
File base/process_util_mac.mm (right):

http://codereview.chromium.org/8160/diff/216/217#newcode22
Line 22: argv_copy[i] = new char[argv[i].size() + 1];
You should be able to remove this copy by using argv[i].c_str(), which will
return a C-style string pointer that's valid until the next non-const method is
called on argv[i] (and does not need to be deleted).