Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 8159009: Build Chrome and WebKit unit tests as part of the Aura build. (Closed)

Created:
9 years, 2 months ago by Emmanuel Saint-loubert-Bié
Modified:
9 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Since both required some effort to compile on ToT this should help avoid regressions. TBR=sky@chromium.org BUG=97131 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104385

Patch Set 1 #

Patch Set 2 : Adding Chrome build target. #

Patch Set 3 : Alpha order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Emmanuel Saint-loubert-Bié
The webkit_unit_tests were fixed earlier this week, now that we build the target 'aura_builder' it ...
9 years, 2 months ago (2011-10-06 01:31:43 UTC) #1
Emmanuel Saint-loubert-Bié
Hi Scott, I fixed webkit_unit_tests earlier this week, now that we build the target 'aura_builder' ...
9 years, 2 months ago (2011-10-06 01:32:22 UTC) #2
sky
We could build them, but is there anything specific to aura that we want to ...
9 years, 2 months ago (2011-10-06 15:52:39 UTC) #3
Emmanuel Saint-loubert-Bié
Hi Scott, I had to to land a couple of WebKit CL and a couple ...
9 years, 2 months ago (2011-10-06 16:58:12 UTC) #4
Emmanuel Saint-loubert-Bié
Hi Scott, PTAL. Thanks! -- Emmanuel
9 years, 2 months ago (2011-10-06 18:09:13 UTC) #5
sky
Does chrome build on windows with aura defined?
9 years, 2 months ago (2011-10-06 19:38:32 UTC) #6
Emmanuel Saint-loubert-Bié
As soon as Ben lands: http://codereview.chromium.org/8174005/ Which is one more reason to do enable this ...
9 years, 2 months ago (2011-10-06 20:50:49 UTC) #7
sky
On 2011/10/06 20:50:49, Emmanuel Saint-loubert wrote: > As soon as Ben lands: http://codereview.chromium.org/8174005/ > > ...
9 years, 2 months ago (2011-10-06 22:22:40 UTC) #8
Emmanuel Saint-loubert-Bié
Landed :-)
9 years, 2 months ago (2011-10-06 23:01:12 UTC) #9
sky
9 years, 2 months ago (2011-10-06 23:12:57 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld 408576698