Add a check to the registry before the intent infobar is shown.

chrome/browser/intents/register_intent_handler_infobar_delegate.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/intents/register_intent_handler_infobar_delegate.h"
 
+#include "base/bind.h"
+#include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/browser/infobars/infobar_tab_helper.h"
 #include "chrome/browser/intents/web_intents_registry.h"
 #include "chrome/browser/intents/web_intents_registry_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 RegisterIntentHandlerInfoBarDelegate::RegisterIntentHandlerInfoBarDelegate(
     InfoBarTabHelper* infobar_helper,
     WebIntentsRegistry* registry,
     const WebIntentServiceData& service)
@@ skipping 34 matching lines @@
   return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
 }
 
 bool RegisterIntentHandlerInfoBarDelegate::LinkClicked(
     WindowOpenDisposition disposition) {
   // TODO(jhawkins): Open the Web Intents Help Center article once it is
   // written.
   // TODO(jhawkins): Add associated bug for the article here.
   return false;
 }
+
+// Helper continuation for MaybeShowIntentInfoBar.
+void CheckProvider(

[James Hawkins, 2011/10/26 23:50:06]

Move to an unnamed namespace.

[Greg Billock, 2011/10/29 00:03:19]

Done.

+    InfoBarTabHelper* infobar_helper,
+    WebIntentsRegistry* registry,

[James Hawkins, 2011/10/26 23:50:06]

Just an FYI: for implementation, parameters may be filled to 80 cols; the only
constraint is that each start of a line of parameters must line up on the same
column. This generally saves line space in the implementation.

[Greg Billock, 2011/10/29 00:03:19]

Moved these up and indented.

On 2011/10/26 23:50:06, James Hawkins wrote:

+    const WebIntentServiceData& service,
+    bool provider_exists) {
+  if (!provider_exists) {

[James Hawkins, 2011/10/26 23:50:06]

Perhaps this parameter could be removed and the continuation only called if it
does not exist?

[Greg Billock, 2011/10/29 00:03:19]

Hmmm. So the signature is something like NotifyIfIntentProviderDoesNotExist...
I'm not sure that's least surprising, although it's definitely nicer for this
case.

+    infobar_helper->AddInfoBar(new RegisterIntentHandlerInfoBarDelegate(
+        infobar_helper, registry, service));
+  }
+}
+
+// static
+void RegisterIntentHandlerInfoBarDelegate::MaybeShowIntentInfoBar(
+    InfoBarTabHelper* infobar_helper,
+    WebIntentsRegistry* registry,
+    const WebIntentServiceData& service) {
+  DCHECK(infobar_helper);
+  DCHECK(registry);
+  registry->IntentProviderExists(service,
+                                 base::Bind(&CheckProvider,
+                                            base::Unretained(infobar_helper),
+                                            base::Unretained(registry),
+                                            service));
+}