Add a check to the registry before the intent infobar is shown.

chrome/browser/webdata/web_data_service_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 621 matching lines @@
   wds_->GetWebIntents(ASCIIToUTF16("share"), &consumer);
   WebIntentsConsumer::WaitUntilCalled();
   ASSERT_EQ(1U, consumer.intents.size());
 
   service.type = ASCIIToUTF16("video/*");
   EXPECT_EQ(service.service_url, consumer.intents[0].service_url);
   EXPECT_EQ(service.action, consumer.intents[0].action);
   EXPECT_EQ(service.type, consumer.intents[0].type);
 }
 
+TEST_F(WebDataServiceTest, WebIntentsForURL) {
+  WebIntentsConsumer consumer;
+
+  WebIntentServiceData service;
+  service.service_url = GURL("http://google.com");
+  service.action = ASCIIToUTF16("share1");

[James Hawkins, 2011/10/06 20:55:03]

Wha?  Why did you make this share1?  The point of my suggestion to register two
actions was so we'd return two actions instead of just one.  Also, now that I
think about it, the name of this method is misleading, since we're getting web
intents ForURLAndAction.  I really think it should just be URL (in the
implementation as well).

[Greg Billock, 2011/10/06 21:37:57]

Hmm. I see what you're saying about naming. The existing method should perhaps
be "GetWebIntentsForAction".

If we're reading by service_url, we may as well go back to the way I was doing
it before; it'll require a full table scan unless we add a service_url index. I
don't know if that's reasonable or not -- the action index will probably be
quite weak in practice. How expensive are multiple sqlite indices?

[James Hawkins, 2011/10/06 21:42:32]

*shrugs*

[Greg Billock, 2011/10/06 22:13:12]

As in "indices aren't that bad" or as in "oh well, full table scans aren't so
bad" or as in "yeah, let's just look up by action and url, then"?

SQLite docs I found suggest indices can be harmful for small tables; it's faster
to just scan. I'm not sure what 'small' means, though.

[James Hawkins, 2011/10/07 20:29:48]

Per-offline, I wouldn't try to optimize this yet (and I don't know the answer to
your question).

+  service.type = ASCIIToUTF16("image/*");
+  wds_->AddWebIntent(service);
+
+  service.action = ASCIIToUTF16("share");
+  service.type = ASCIIToUTF16("image/*");
+  wds_->AddWebIntent(service);
+
+  wds_->GetWebIntentsForURL(
+      ASCIIToUTF16("share"),
+      UTF8ToUTF16(service.service_url.spec()),
+      &consumer);
+  WebIntentsConsumer::WaitUntilCalled();
+  ASSERT_EQ(1U, consumer.intents.size());
+  EXPECT_EQ(service, consumer.intents[0]);
+}
+
 TEST_F(WebDataServiceTest, WebIntentsGetAll) {
   WebIntentsConsumer consumer;
 
   WebIntentServiceData service;
   service.service_url = GURL("http://google.com");
   service.action = ASCIIToUTF16("share");
   service.type = ASCIIToUTF16("image/*");
   wds_->AddWebIntent(service);
 
   service.action = ASCIIToUTF16("edit");
   wds_->AddWebIntent(service);
 
   wds_->GetAllWebIntents(&consumer);
   WebIntentsConsumer::WaitUntilCalled();
   ASSERT_EQ(2U, consumer.intents.size());
 
   if (consumer.intents[0].action != ASCIIToUTF16("edit"))
     std::swap(consumer.intents[0],consumer.intents[1]);
 
   EXPECT_EQ(service, consumer.intents[0]);
   service.action = ASCIIToUTF16("share");
   EXPECT_EQ(service, consumer.intents[1]);
 }