Upstream: The script to install Android SDK, NDK.

build/install-build-deps-android.sh

+#!/bin/bash

[Mark Mentovai, 2011/10/05 23:09:22]

You got rid of the -e but didn’t put in a “set -e” as I asked.

It’s a very good idea to run your scripts under -e.

[michaelbai, 2011/10/06 17:23:19]

Done.

+
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# The script is to install Android SDK, NDK for build chromium on Android, and
+# doesn't need to run as root.
+
+# Using Android 3.2, API Level: 13 (Honeycomb). The SDK package is about 30M.
+SDK_FILE_NAME="android-sdk_r13-linux_x86.tgz"
+SDK_DOWNLOAD_URL="http://dl.google.com/android/android-sdk_r13-linux_x86.tgz"

[Mark Mentovai, 2011/10/05 23:09:22]

Seems like this could end in ${SDK_FILE_NAME}. Same on line 29.

[michaelbai, 2011/10/06 17:23:19]

Done.

+SDK_MD5SUM="d80d7530a46c665644ae76084a9a0dc4"
+
+# Using "ANDROID_SDK_ROOT/tools/android list targets" to get the matching target
+# id which will be loaded in simulator for testing.
+# For example: the output of the listed the target could be below, and the
+# 'android-13' is the SDK_TARGET_ID in this case.
+# id: 9 or "android-13"
+#     Name: Android 3.2
+#     Type: Platform
+#     API level: 13
+#     Revision: 1
+#     Skins: WXGA (default)
+SDK_TARGET_ID=android-13
+
+# Using NDK r6b; The package is about 44M.
+NDK_FILE_NAME="android-ndk-r6b-linux-x86.tar.bz2"
+NDK_DOWNLOAD_URL="http://dl.google.com/android/ndk/android-ndk-r6b-linux-x86.tar.bz2"
+NDK_MD5SUM="309f35e49b64313cfb20ac428df4cec2"
+
+##########################################################
+# Download and install a tgz package by wget and tar -xvf.
+# Arguments:
+#   local_file_name, the name of downloaded file.
+#   download_url, the url to download the package.
+#   md5, the package's md5 which could be found in download page.
+#   install_path, where the package should be installed.
+# Returns:
+#   None
+##########################################################
+install_dev_kit() {
+  local local_file_name="${1}"
+  local download_url="${2}"
+  local md5="${3}"
+  local install_path="${4}"
+
+  if [[ ! -f "${local_file_name}" ]]; then
+    wget "${download_url}"

[Mark Mentovai, 2011/10/05 23:09:22]

This just drops stuff into the current directory. The current directory could be
anything! That’s no good. This should probably work with some sort of temporary
directory. You can get a temporary directory with TEMPDIR=$(mktemp -d). Be sure
to remove your temporary directory when the script exits, whether it’s a clean
exit or not.

[michaelbai, 2011/10/06 17:23:19]

Done.

+  fi
+
+  if [[ $(md5sum "${local_file_name}" | cut -d' ' -f1) != "${md5}" ]]; then
+    echo "Bad md5sum of ${local_file_name}, " >& 2

[Mark Mentovai, 2011/10/05 23:09:22]

This doesn’t need to end in a comma.

You might want to print the expected and computed MD5 checksums. You could stick
the result of $(md5sum …) into a variable like computed_md5, compare that to
md5, and then echo them both out on this line.

[michaelbai, 2011/10/06 17:23:19]

Done.

+    rm "${local_file_name}"
+    exit 1
+  fi
+
+  echo "Install ${local_file_name}"
+  mv "${local_file_name}" "${install_path}"
+  if [[ "$?" -ne 0 ]]; then

[Mark Mentovai, 2011/10/05 23:09:22]

If you’re running under -e, the script will die before it gets to this point, so
you can get rid of this check.

[michaelbai, 2011/10/06 17:23:19]

Done.

+    echo "Unable to move ${local_file_name} to ${install_path}" >&2
+    exit 1
+  fi
+  (cd "${install_path}" && tar -xvf "${local_file_name}")
+}
+
+if [[ -z "${ANDROID_SDK_ROOT}" ]]; then
+  echo "Please set ANDROID_SDK_ROOT to where they should installed to." >& 2
+  echo "For example: /usr/local/android-sdk-linux_x86" >& 2
+  exit 1
+fi
+
+if [[ -z "${ANDROID_NDK_ROOT}" ]]; then
+  echo "Please set ANDROID_NDK_ROOT to where they should installed to." >& 2
+  echo "For example: /usr/local/android-ndk-r6b" >& 2
+  exit 1
+fi
+
+# Install Android SDK if it doesn't exist.
+if [[ ! -d "${ANDROID_SDK_ROOT}" ]]; then
+  echo 'Install ANDROID SDK ...'
+  install_dev_kit "${SDK_FILE_NAME}" "${SDK_DOWNLOAD_URL}" "${SDK_MD5SUM}" \
+                  $(dirname "${ANDROID_SDK_ROOT}")
+fi
+
+# Install the target if it doesn't exist. The package installed above contains
+# no platform, platform-tool or tool, all those should be installed by
+# ${ANDROID_SDK_ROOT}/tools/android.
+if [[ ! $("${ANDROID_SDK_ROOT}"/tools/android list targets \

[Mark Mentovai, 2011/10/05 23:09:22]

Usually you just wrap the quotes around the entire word, not just the variable
expansion, like "${ANDROID_SDK_ROOT}/tools/android". Same on line 95 and 103.

[michaelbai, 2011/10/06 17:23:19]

Done, Shall I know what's the difference?

On 2011/10/05 23:09:22, Mark Mentovai wrote:

+  | grep -q "${SDK_TARGET_ID}") ]]; then
+  # Updates the SDK by installing the necessary components.
+  # From current configuration, all android platforms will be installed.
+  # This will take a little bit long time.
+  echo "Install platform, platform-tool and tool ..."
+  "${ANDROID_SDK_ROOT}"/tools/android update sdk --no-ui \
+    --filter platform,platform-tool,tool
+fi
+
+# Create a Android Virtual Device named 'buildbot' with default hardware
+# configuration and override the existing one, since there is no easy way to
+# check whether current AVD has correct configuration and it takes almost no
+# time to create a new one.
+"${ANDROID_SDK_ROOT}"/tools/android --silent create avd --name buildbot \
+  --target ${SDK_TARGET_ID} --force <<< "no"
+
+# Install Android NDK if it doesn't exist.
+if [[ ! -d "${ANDROID_NDK_ROOT}" ]]; then
+  echo 'Install ANDROID NDK ...'
+  install_dev_kit "${NDK_FILE_NAME}" "${NDK_DOWNLOAD_URL}" "${NDK_MD5SUM}" \
+                  $(dirname "${ANDROID_NDK_ROOT}")
+fi