Issue 8144011: Fix a prototype chain traversal not expecting proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8144011: Fix a prototype chain traversal not expecting proxies. (Closed)

Created:
9 years, 2 months ago by rossberg

Modified:
9 years, 2 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix a prototype chain traversal not expecting proxies. R=kmillikin@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9536

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

lgtm OK. I wonder if there's a way to catch all of these?

9 years, 2 months ago (2011-10-06 08:00:40 UTC) #2

rossberg

9 years, 2 months ago (2011-10-06 08:39:43 UTC) #3

On 2011/10/06 08:00:40, Kevin Millikin wrote:
> OK.  I wonder if there's a way to catch all of these?

Yes, wondering that, too.  But apart from naive grepping and even more test
cases I don't really see any. :(

BTW, I didn't include a test case for this one, but I'm working on another CL
fixing corner cases related to unexpected side effects during property lookup,
and that tests this, too.

Expand Messages | Collapse Messages