Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 8143022: Have the DEPS only parsed in the relevant thread. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Have the DEPS only parsed in the relevant thread. This means parsing the DEPS file all the time preemptively in case it's needed for a From() reference. This could break certain checkout, we'll see. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104817

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase against 8142030 #

Patch Set 3 : Rebase against 8142030 / 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M gclient.py View 1 2 4 chunks +7 lines, -16 lines 0 comments Download
M tests/gclient_test.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-10-05 16:44:56 UTC) #1
Dirk Pranke
lgtm http://codereview.chromium.org/8143022/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/8143022/diff/1/gclient.py#newcode345 gclient.py:345: if len(found_deps) != 1: is it possible for ...
9 years, 2 months ago (2011-10-05 21:08:28 UTC) #2
M-A Ruel
http://codereview.chromium.org/8143022/diff/1/gclient.py File gclient.py (right): http://codereview.chromium.org/8143022/diff/1/gclient.py#newcode345 gclient.py:345: if len(found_deps) != 1: On 2011/10/05 21:08:28, Dirk Pranke ...
9 years, 2 months ago (2011-10-06 13:10:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8143022/8001
9 years, 2 months ago (2011-10-10 23:11:31 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-10 23:17:40 UTC) #5
Change committed as 104817

Powered by Google App Engine
This is Rietveld 408576698