Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 8143021: aura: Fix views_unittests on linux. (Closed)

Created:
9 years, 2 months ago by sadrul
Modified:
9 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Paweł Hajdan Jr., dhollowa
Visibility:
Public.

Description

aura: Fix views_unittests and aura_unittests on linux. . Use NativeScrollBarViews in aura and wayland. . Disable clipboard-related tests in TextfieldViewsModelTest until aura on linux has clipboard support. . Use osmesa implementation for aura_unittests. TBR=evan@chromium.org BUG=97845, 99128 TEST=views_unittests passes on linux with use_aura Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104220

Patch Set 1 #

Patch Set 2 : mark test as DISABLED_ rather than FAILED_ #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : make sure the display is initialized #

Patch Set 5 : aura_unittests also go green #

Patch Set 6 : . #

Patch Set 7 : removed textfield tests changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M base/message_pump_x.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test_suite.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar.cc View 2 chunks +4 lines, -24 lines 0 comments Download
M views/controls/scrollbar/native_scroll_bar_views.cc View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
D views/controls/scrollbar/native_scroll_bar_wayland.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M views/controls/textfield/textfield_views_model_unittest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
9 years, 2 months ago (2011-10-05 16:36:42 UTC) #1
sky
LGTM
9 years, 2 months ago (2011-10-05 17:05:18 UTC) #2
sadrul
I had to mark a few more tests as DISABLED_, and changed from FAILS_ to ...
9 years, 2 months ago (2011-10-05 18:16:13 UTC) #3
sky
http://codereview.chromium.org/8143021/diff/2002/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/8143021/diff/2002/views/controls/textfield/native_textfield_views_unittest.cc#newcode39 views/controls/textfield/native_textfield_views_unittest.cc:39: #define MAYBE_KeyTest DISABLED_KeyTest These don't crash on windows (as ...
9 years, 2 months ago (2011-10-05 20:28:03 UTC) #4
sadrul
I also included a compile fix for layer_unittests http://codereview.chromium.org/8143021/diff/2002/views/controls/textfield/native_textfield_views_unittest.cc File views/controls/textfield/native_textfield_views_unittest.cc (right): http://codereview.chromium.org/8143021/diff/2002/views/controls/textfield/native_textfield_views_unittest.cc#newcode39 views/controls/textfield/native_textfield_views_unittest.cc:39: #define ...
9 years, 2 months ago (2011-10-05 20:42:35 UTC) #5
sky
SLGTM
9 years, 2 months ago (2011-10-05 22:02:07 UTC) #6
sadrul
9 years, 2 months ago (2011-10-06 01:22:44 UTC) #7
I removed the changes from native_textfield_views_unittest.cc from this CL in
favour of http://codereview.chromium.org/8150001/. Landing the rest.

Powered by Google App Engine
This is Rietveld 408576698