src/api.cc - Issue 8143018: Revert "Added ability to lock strings to prevent their representation or encoding from changing."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 8143018: Revert "Added ability to lock strings to prevent their representation or encoding from changing." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index ee06456516e3c457d334c845f926a3c3ea0451c3..7266390a42df0da865aa0213713f95d87cb218de 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -4451,9 +4451,6 @@ bool v8::String::MakeExternal(v8::String::ExternalStringResource* resource) {

if (isolate->string_tracker()->IsFreshUnusedString(obj)) {

return false;

}

- if (isolate->heap()->IsStringLocked(*obj)) {

- return false;

- }

if (isolate->heap()->IsInGCPostProcessing()) {

return false;

}

« no previous file with comments | « no previous file | src/handles.h » ('j') | no next file with comments »