Issue 8143007: Move a bunch of non-shared methods out of the FormGroup class.

Issue 8143007: Move a bunch of non-shared methods out of the FormGroup class. (Closed)

Created:
9 years, 2 months ago by Ilya Sherman

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, dhollowa

CC:
chromium-reviews, GeorgeY, Paweł Hajdan Jr., Ilya Sherman, dyu1, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move a bunch of non-shared methods out of the FormGroup class. Some of them can be removed completely! BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104045

Patch Set 2 : De-nitting #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -197 lines)			Patch
M	chrome/browser/autofill/autofill_profile.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_profile.cc	View	1	4 chunks	+31 lines, -9 lines	0 comments	Download
M	chrome/browser/autofill/autofill_profile_unittest.cc	View		1 chunk	+0 lines, -62 lines	0 comments	Download
M	chrome/browser/autofill/credit_card.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/autofill/form_group.h	View		2 chunks	+1 line, -20 lines	0 comments	Download
M	chrome/browser/autofill/form_group.cc	View		1 chunk	+0 lines, -68 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.cc	View		1 chunk	+6 lines, -31 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/autofill/merge/input/primarycase.in	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dhollowa

LGTM w/ nit. http://codereview.chromium.org/8143007/diff/1/chrome/browser/autofill/autofill_profile.cc File chrome/browser/autofill/autofill_profile.cc (right): http://codereview.chromium.org/8143007/diff/1/chrome/browser/autofill/autofill_profile.cc#newcode578 chrome/browser/autofill/autofill_profile.cc:578: if (!CaseInsensitiveStringEquals()(GetInfo(*iter), new_value)) This is a ...

9 years, 2 months ago (2011-10-04 22:47:38 UTC) #3

Ilya Sherman

http://codereview.chromium.org/8143007/diff/1/chrome/browser/autofill/autofill_profile.cc File chrome/browser/autofill/autofill_profile.cc (right): http://codereview.chromium.org/8143007/diff/1/chrome/browser/autofill/autofill_profile.cc#newcode578 chrome/browser/autofill/autofill_profile.cc:578: if (!CaseInsensitiveStringEquals()(GetInfo(*iter), new_value)) On 2011/10/04 22:47:39, dhollowa wrote: > ...

9 years, 2 months ago (2011-10-04 23:06:55 UTC) #4

commit-bot: I haz the power

CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8143007/1010

9 years, 2 months ago (2011-10-04 23:08:28 UTC) #5

Change committed as 104045

Expand Messages | Collapse Messages