Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 8142040: Merge 96552 - REGRESSION(r94274): cloned text input loses value (Closed)

Created:
9 years, 2 months ago by rniwa-cr
Modified:
9 years, 2 months ago
Reviewers:
rniwa
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 96552 - REGRESSION(r94274): cloned text input loses value https://bugs.webkit.org/show_bug.cgi?id=69095 Reviewed by Darin Adler. Source/WebCore: The bug was caused by copyNonAttributeProperties not updating inner element text after copying m_valueIfDirty. Fixed the bug by calling updateInnerTextValue. Test: fast/forms/clone-input-with-dirty-value.html * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): LayoutTests: Added a regression test that clones an input element with a dirty value. The cloned input element should have the edited value. * fast/forms/clone-input-with-dirty-value-expected.txt: Added. * fast/forms/clone-input-with-dirty-value.html: Added. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, --2 lines) Patch
A + LayoutTests/fast/forms/clone-input-with-dirty-value.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/clone-input-with-dirty-value-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLInputElement.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
9 years, 2 months ago (2011-10-05 18:35:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698