Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 8142032: Add error description to the DidFailProvisionalLoad callback. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: rebase Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/mock_content_renderer_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index a0f8bbadb873d891980c2319d320ed872d680693..362525cfa83f07b66aa59befc2b1ff0e6b9db978 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -70,10 +70,19 @@ class ContentRendererClient {
virtual bool HasErrorPage(int http_status_code,
std::string* error_domain) = 0;
- // Returns the html to display when a navigation error occurs.
- virtual std::string GetNavigationErrorHtml(
+ // Returns the information to display when a navigation error occurs.
+ // If |error_html| is not null then it may be set to a HTML page containing
+ // the details of the error and maybe links to more info.
+ // If |error_description| is not null it may be set to contain a brief
+ // message describing the error that has occurred.
+ // Either of the out parameters may be not written to in certain cases
+ // (lack of information on the error code) so the caller should take care to
+ // initialize the string values with safe defaults before the call.
+ virtual void GetNavigationErrorStrings(
const WebKit::WebURLRequest& failed_request,
- const WebKit::WebURLError& error) = 0;
+ const WebKit::WebURLError& error,
+ std::string* error_html,
+ string16* error_description) = 0;
// Returns true if the renderer process should schedule the idle handler when
// all widgets are hidden.
« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/mock_content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698